Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KibanaServices singleton with useKibana hook #173071

Closed
tiansivive opened this issue Dec 11, 2023 · 0 comments · Fixed by #173302
Closed

Replace KibanaServices singleton with useKibana hook #173071

tiansivive opened this issue Dec 11, 2023 · 0 comments · Fixed by #173302
Assignees
Labels
Team:Entity Analytics Security Entity Analytics Team

Comments

@tiansivive
Copy link
Contributor

tiansivive commented Dec 11, 2023

In /x-pack/plugins/security_solution/public/entity_analytics/api/api.ts, the fetch calls should be updated to use the useKibana Hook

This was originally pointed out here

This implies carefully restructuring the call sites, as there's no guarantees that they're all within hooks already.
For example, they could be called onClick event handlers or as part of the queryFn for react-query.

https://github.com/tiansivive/kibana/blob/b18a7aeecf160ea4fd60892f6a1768b4466da6c4/x-pack/plugins/security_solution/public/entity_analytics/api/api.ts#L32

@tiansivive tiansivive self-assigned this Dec 11, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 11, 2023
@tiansivive tiansivive added Team:Entity Analytics Security Entity Analytics Team and removed needs-team Issues missing a team label labels Dec 11, 2023
@tiansivive tiansivive mentioned this issue Dec 11, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Entity Analytics Security Entity Analytics Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant