-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/rule_creation/esql_rule_ess·cy·ts - Detection ES|QL rules, creation ES|QL query validation shows error when ES|QL query is invalid shows error when ES|QL query is invalid #173006
Labels
failed-test
A test failure on a tracked branch, potentially flaky-test
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
triage_needed
Comments
kibanamachine
added
the
failed-test
A test failure on a tracked branch, potentially flaky-test
label
Dec 9, 2023
wayneseymour
added
the
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
label
Dec 12, 2023
Pinging @elastic/security-solution (Team: SecuritySolution) |
yctercero
added
the
Team:Detection Engine
Security Solution Detection Engine Area
label
Dec 12, 2023
Hey @vitaliidm - this one is reporting a failure, not anything skipped yet. Might be good to confirm if it's a legit flake. If not, we can close out. Thanks so much! |
MadameSheema
added
triage_needed
Team:Detections and Resp
Security Detection Response Team
labels
Dec 13, 2023
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
1 task
vitaliidm
added a commit
that referenced
this issue
Jan 2, 2024
## Summary - fixes flaky ES|QL tests #173006 - the reason is an issue in cypress itself cypress-io/cypress#22113. It doesn't have a fix yet, but I tried some suggested workaround, as calling `uncaught:exception` handler after page is opened, so it is registered in the same origin. Which seemed to help, since there was no failures in 300 runs. Usual rate of flakiness before the fix was 3-7 failures per 100 runs. Hopefully, it will work and we won't see any errors in future. ### Checklist Delete any items that are not applicable to this PR. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - 100 runs for all Detection tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625 - 2 x 100 for just failing ones: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620, https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605 --------- Co-authored-by: kibanamachine <[email protected]>
fixed in #173251 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jan 2, 2024
…c#173251) ## Summary - fixes flaky ES|QL tests elastic#173006 - the reason is an issue in cypress itself cypress-io/cypress#22113. It doesn't have a fix yet, but I tried some suggested workaround, as calling `uncaught:exception` handler after page is opened, so it is registered in the same origin. Which seemed to help, since there was no failures in 300 runs. Usual rate of flakiness before the fix was 3-7 failures per 100 runs. Hopefully, it will work and we won't see any errors in future. ### Checklist Delete any items that are not applicable to this PR. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - 100 runs for all Detection tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625 - 2 x 100 for just failing ones: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620, https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit b365051)
kibanamachine
added a commit
that referenced
this issue
Jan 2, 2024
…173251) (#174099) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)](#173251) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vitalii Dmyterko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-02T16:00:08Z","message":"[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)\n\n## Summary\r\n\r\n- fixes flaky ES|QL tests\r\nhttps://github.com//issues/173006\r\n- the reason is an issue in cypress itself\r\nhttps://github.com/cypress-io/cypress/issues/22113. It doesn't have a\r\nfix yet, but I tried some suggested workaround, as calling\r\n`uncaught:exception` handler after page is opened, so it is registered\r\nin the same origin. Which seemed to help, since there was no failures in\r\n300 runs. Usual rate of flakiness before the fix was 3-7 failures per\r\n100 runs. Hopefully, it will work and we won't see any errors in future.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- 100 runs for all Detection tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625\r\n- 2 x 100 for just failing ones:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620,\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b365051dc24156d810004917efa64dbcbaa64a59","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","v8.12.0","v8.13.0"],"title":"[Security Solution][Detection Engine] fixes flaky ES|QL tests","number":173251,"url":"https://github.com/elastic/kibana/pull/173251","mergeCommit":{"message":"[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)\n\n## Summary\r\n\r\n- fixes flaky ES|QL tests\r\nhttps://github.com//issues/173006\r\n- the reason is an issue in cypress itself\r\nhttps://github.com/cypress-io/cypress/issues/22113. It doesn't have a\r\nfix yet, but I tried some suggested workaround, as calling\r\n`uncaught:exception` handler after page is opened, so it is registered\r\nin the same origin. Which seemed to help, since there was no failures in\r\n300 runs. Usual rate of flakiness before the fix was 3-7 failures per\r\n100 runs. Hopefully, it will work and we won't see any errors in future.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- 100 runs for all Detection tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625\r\n- 2 x 100 for just failing ones:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620,\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b365051dc24156d810004917efa64dbcbaa64a59"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173251","number":173251,"mergeCommit":{"message":"[Security Solution][Detection Engine] fixes flaky ES|QL tests (#173251)\n\n## Summary\r\n\r\n- fixes flaky ES|QL tests\r\nhttps://github.com//issues/173006\r\n- the reason is an issue in cypress itself\r\nhttps://github.com/cypress-io/cypress/issues/22113. It doesn't have a\r\nfix yet, but I tried some suggested workaround, as calling\r\n`uncaught:exception` handler after page is opened, so it is registered\r\nin the same origin. Which seemed to help, since there was no failures in\r\n300 runs. Usual rate of flakiness before the fix was 3-7 failures per\r\n100 runs. Hopefully, it will work and we won't see any errors in future.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- 100 runs for all Detection tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4625\r\n- 2 x 100 for just failing ones:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4620,\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4605\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b365051dc24156d810004917efa64dbcbaa64a59"}}]}] BACKPORT--> Co-authored-by: Vitalii Dmyterko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
failed-test
A test failure on a tracked branch, potentially flaky-test
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
triage_needed
A test failed on a tracked branch
First failure: CI Build - main
The text was updated successfully, but these errors were encountered: