[lens] lens embeddable continuously shows loading icon on failure

[nreese]

Steps

1. install sample web logs
2. create new dashboard
3. Click "Create visualization"
4. Drag "timestamp" field into workspace."
5. Add filter

   {
     "error_query": {
       "indices": [
         {
           "error_type": "exception",
           "message": "local shard failure message 123",
           "name": "kibana_sample_data_logs"
         }
       ]
     }
   }
   

6. Click "Save and return"
7. Notice how panel shows loading icon under error message
   

Note: The issue only happens when filter is contained in the lens visualization. If you just add the filter to the dashboard, the problem does not exist.

[elasticmachine]

Pinging @elastic/kibana-visualizations (Team:Visualizations)

[drewdaemon]

Unfortunately, this is probably due to the Lens embeddable not notifying render complete when errors are shown. We got away with this until #171238

[nreese]

Unfortunately, this is probably due to the Lens embeddable not notifying render complete when errors are shown. We got away with this until #171238

Would this impact reporting? Maybe the priority should be higher if it causes reporting to timeout

[drewdaemon]

Actually, I said render complete, but I think it is the loading output property. It seems like we have error, loading, and rendered. I'm thinking reporting relies on the rendered prop. But, it's funky because I can report an error and the embeddable panel treats that independently of whether the panel is loading or rendered AFAICT.

kibana/src/plugins/embeddable/public/lib/embeddables/i_embeddable.ts

Lines 20 to 25 in c86d437

	// Whether the embeddable is actively loading.
	loading?: boolean;
	// Whether the embeddable is rendered.
	rendered?: boolean;
	// Whether the embeddable finished loading with an error.
	error?: EmbeddableError;