[lens] show 'View details' UI action to open clusters inspector tab when request fails #172971

nreese · 2023-12-08T16:33:05Z

PR make the following changes

Consolidates data EsError logic and Lens EsError logic. This resulted in being able to remove large parts of lens error_helper.tsx file.
Consolidates lens WorkspacePanel error logic. Before PR configuration errors and data loading errors each rendered their own version of EuiEmptyPrompt with slightly different behavior. Now, both render WorkspaceErrors component and have the same behavior
Updated lens ExpressionWrapper to return original error to embeddable output.

Test - EsError in embeddable

install sample web logs
create new dashboard
Click "Create visualization"
Drag "timestamp" field into workspace.
Click "Save and return"

Add filter

{
  "error_query": {
    "indices": [
      {
        "error_type": "exception",
        "message": "local shard failure message 123",
        "name": "kibana_sample_data_logs"
      }
    ]
  }
}

Verify EsError and "View details" action are displayed

Test - multiple configuration errors in lens editor

install sample web logs
create new lens visualization
Drag "timestamp" field into workspace.

Add filter

{
  "error_query": {
    "indices": [
      {
        "error_type": "exception",
        "message": "local shard failure message 123",
        "name": "kibana_sample_data_logs"
      }
    ]
  }
}

Verify EsError and "View details" action are displayed

Test - EsError in embeddable

install sample web logs
create new dashboard
Click "Create visualization"
Drag "timestamp" field into workspace.
Change "Vertical axis" to "Cumulative sum". Select "Field" select and hit delete key
Clone layer one or more times
Verify pagination is displayed, allowing users to click through all configuration errors

nreese · 2023-12-08T17:14:17Z

/ci

…-fix'

nreese · 2023-12-08T18:43:21Z

@elasticmachine merge upstream

nreese · 2023-12-08T20:16:58Z

/ci

…-fix'

nreese · 2023-12-08T22:58:42Z

/ci

…-fix'

nreese · 2023-12-10T16:22:46Z

/ci

nreese · 2023-12-10T16:48:17Z

@elasticmachine merge upstream

nreese · 2023-12-10T16:48:35Z

/ci

…fix'

…-fix'

nreese · 2023-12-10T17:45:48Z

/ci

nreese · 2023-12-16T20:00:55Z

@elasticmachine merge upstream

kibanamachine · 2023-12-16T20:00:59Z

merge conflict between base and head

nreese · 2023-12-17T15:18:24Z

@elasticmachine merge upstream

elasticmachine · 2023-12-17T15:18:57Z

Pinging @elastic/kibana-presentation (Team:Presentation)

nickpeihl

Presentation changes lgtm!

code review and tested error reporting

lukasolson

Search changes LGTM

stratoula

Works great, LGTM! Thanx Nathan!

dej611

Did a code review and it looks 👌 (left only few minor comments).

On the UI side, wouldn't be better now to show the actual number of errors in the prompt title?

Currently it is just a generic "An error":

WDYT? cc @stratoula @MichaelMarcialis

packages/kbn-search-errors/src/painless_error.tsx

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx

stratoula · 2023-12-20T09:35:03Z

@dej611 yes it is a nit but whatever Michael prefers here. The title in singular can improve and be more generic. I can see the number of errors from the paginated items.

Co-authored-by: Marco Liberati <[email protected]>

nreese · 2023-12-20T15:31:31Z

@elasticmachine merge upstream

kibana-ci · 2023-12-20T16:42:36Z

💚 Build Succeeded

Buildkite Build
Commit: ea17613

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lens`	1154	1155	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/search-errors`	26	17	-9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	592.4KB	592.4KB	-34.0B
`lens`	1.4MB	1.4MB	-3.3KB
`maps`	2.9MB	2.9MB	-41.0B
total			-3.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/search-errors`	0	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	410.6KB	410.6KB	-23.0B
`embeddable`	78.2KB	78.1KB	-44.0B
`kbnUiSharedDeps-srcJs`	2.3MB	2.3MB	+747.0B
total			+680.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/search-errors`	27	18	-9

History

💚 Build #183813 succeeded 1241357
💔 Build #183803 failed 68632e8
💔 Build #183798 failed 915a960
💔 Build #182858 failed 0d443fb
💔 Build #182855 failed 5b5504f
💔 Build #182854 failed 7465c78

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese · 2023-12-20T22:12:49Z

On the UI side, wouldn't be better now to show the actual number of errors in the prompt title?

I am going to merge this since I would like to build on these changes for Maps plugin. Copy updates can be made at a later time

MichaelMarcialis · 2024-01-02T19:51:10Z

On the UI side, wouldn't be better now to show the actual number of errors in the prompt title?

Currently it is just a generic "An error":

WDYT? cc @stratoula @MichaelMarcialis

@dej611, @stratoula, @nreese: Apologies for the late reply, as I was on PTO for the holidays. FWIW, I agree with Marco that including the error count in the title when multiple errors are in play would make for a nice improvement. I'm coming into this conversation a bit sideways, but here are some additional rapid-fire thoughts I had while looking at these screenshots. I'd be happy to discuss further or provide additional design support for these as needed.

If these are indeed errors that are preventing the visualization from being rendered (i.e. not warnings), we should use the error icon from EUI rather than the warning icon in these empty prompts.
The Dashboard app screenshot example above shows an empty prompt without a title. Is this intentional? Why do the other empty prompts have titles but this one doesn't?
Some of the error messages are housed in an EUI code block (monotype font, gray background, and copy button) while others are regular paragraph text. What is the reasoning for this? Should we be consistent with how we present these error messages (either all paragraphs or code blocks)?
Am I correct in assuming that the "View details" button would open the same inspect flyout that you and I have discussed in our previous work on remote cluster errors? If so, do we even need the error pagination shown in the last example screenshot above? Would it be better to take an approach that is consistent with our work on remote cluster errors and simply have a general error message and count, with the "View details" button allowing users to view all the error(s) details in the flyout? Here's one of the mockups of our work on multiple erroneous clusters empty prompt below:

stratoula · 2024-01-03T07:07:37Z

I created a feature request here #174143. The new design seems much better @MichaelMarcialis I agree

nreese added 2 commits December 8, 2023 09:31

move lens EsError functionallity into search-errors package

1f1aa96

update lens

0505817

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

1bd6cd5

…-fix'

kibanamachine and others added 3 commits December 8, 2023 13:43

Merge branch 'main' into issue_171570

e7930e0

PaginatedErrors

a2c7f4a

i18n clean up

6a51c26

kibanamachine and others added 5 commits December 8, 2023 20:52

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

9ad7180

…-fix'

rename

6b2b728

use renderSearchError in EsError tests

24313c1

rename

5534753

fix workspace panel test

43694f4

kibanamachine and others added 2 commits December 8, 2023 23:41

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

db24014

…-fix'

fix functional tests

7465c78

fix lens tests

fa413a6

nreese force-pushed the issue_171570 branch from d7e4227 to fa413a6 Compare December 10, 2023 16:47

Merge branch 'main' into issue_171570

5b5504f

kibanamachine added 2 commits December 10, 2023 16:54

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

4417b73

…fix'

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

0d443fb

…-fix'

clean up

1a79bc4

merge with main

2090896

nreese requested review from a team as code owners December 17, 2023 15:18

Merge branch 'main' into issue_171570

1241357

botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 17, 2023

nreese added release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.13.0 and removed Feature:Embedding Embedding content via iFrame labels Dec 17, 2023

nickpeihl approved these changes Dec 18, 2023

View reviewed changes

botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 18, 2023

lukasolson approved these changes Dec 18, 2023

View reviewed changes

stratoula approved these changes Dec 19, 2023

View reviewed changes

dej611 reviewed Dec 20, 2023

View reviewed changes

packages/kbn-search-errors/src/painless_error.tsx Outdated Show resolved Hide resolved

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx Outdated Show resolved Hide resolved

nreese and others added 2 commits December 20, 2023 08:24

Update packages/kbn-search-errors/src/painless_error.tsx

83fe5ac

Co-authored-by: Marco Liberati <[email protected]>

return empty array instead of array with empty string

b6ab775

Merge branch 'main' into issue_171570

ea17613

nreese requested a review from dej611 December 20, 2023 20:53

nreese merged commit f2ad024 into elastic:main Dec 20, 2023
36 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Dec 20, 2023

stratoula mentioned this pull request Jan 3, 2024

[Lens] Improve error UI #174143

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lens] show 'View details' UI action to open clusters inspector tab when request fails #172971

[lens] show 'View details' UI action to open clusters inspector tab when request fails #172971

nreese commented Dec 8, 2023 •

edited

Loading

nreese commented Dec 8, 2023

nreese commented Dec 8, 2023

nreese commented Dec 8, 2023

nreese commented Dec 8, 2023

nreese commented Dec 10, 2023

nreese commented Dec 10, 2023

nreese commented Dec 10, 2023

nreese commented Dec 10, 2023

nreese commented Dec 16, 2023

kibanamachine commented Dec 16, 2023

nreese commented Dec 17, 2023

elasticmachine commented Dec 17, 2023

nickpeihl left a comment

lukasolson left a comment

stratoula left a comment

dej611 left a comment

stratoula commented Dec 20, 2023

nreese commented Dec 20, 2023

kibana-ci commented Dec 20, 2023

API count

nreese commented Dec 20, 2023

MichaelMarcialis commented Jan 2, 2024 •

edited

Loading

stratoula commented Jan 3, 2024 •

edited

Loading

[lens] show 'View details' UI action to open clusters inspector tab when request fails #172971

[lens] show 'View details' UI action to open clusters inspector tab when request fails #172971

Conversation

nreese commented Dec 8, 2023 • edited Loading

Test - EsError in embeddable

Test - multiple configuration errors in lens editor

Test - EsError in embeddable

nreese commented Dec 8, 2023

nreese commented Dec 8, 2023

nreese commented Dec 8, 2023

nreese commented Dec 8, 2023

nreese commented Dec 10, 2023

nreese commented Dec 10, 2023

nreese commented Dec 10, 2023

nreese commented Dec 10, 2023

nreese commented Dec 16, 2023

kibanamachine commented Dec 16, 2023

nreese commented Dec 17, 2023

elasticmachine commented Dec 17, 2023

nickpeihl left a comment

Choose a reason for hiding this comment

lukasolson left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

dej611 left a comment

Choose a reason for hiding this comment

stratoula commented Dec 20, 2023

nreese commented Dec 20, 2023

kibana-ci commented Dec 20, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

History

nreese commented Dec 20, 2023

MichaelMarcialis commented Jan 2, 2024 • edited Loading

stratoula commented Jan 3, 2024 • edited Loading

nreese commented Dec 8, 2023 •

edited

Loading

MichaelMarcialis commented Jan 2, 2024 •

edited

Loading

stratoula commented Jan 3, 2024 •

edited

Loading