Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling a visualization edit breaks the other panels in managed dashboards #172953

Closed
drewdaemon opened this issue Dec 8, 2023 · 5 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@drewdaemon
Copy link
Contributor

Kibana version:
8.11

Original install method (e.g. download page, yum, from source, etc.):
Via integration asset installation

Describe the bug:
Editing a visualization panel and then cancelling leaves all the other panels on the dashboard in an infinite loading state.

Steps to reproduce:

  1. Install the assets for an integration
  2. Run elastic-package edit dashboard (can download latest version of elastic-package here)
  3. Select a dashboard to make it editable
  4. Visit that dashboard in Kibana
  5. Enter dashboard edit mode
  6. Click "Edit visualization" on a Lens panel (flyout should open)
  7. Click "Cancel"

Expected behavior:
All the panels should be restored (showing their visualizations)

Screenshots (if relevant):

Errors in browser console (if relevant):

Uncaught (in promise) Error: Embeddable has been destroyed
    at visualize_embeddable_VisualizeEmbeddable.render (embeddable.plugin.js:1:7542)
    at visualize_embeddable_VisualizeEmbeddable.render (visualizations.chunk.10.js:1:9133)
    at embeddable.chunk.2.js:1:9050
    at $c (kbn-ui-shared-deps-npm.dll.js:425:106432)
    at t.unstable_runWithPriority (kbn-ui-shared-deps-npm.dll.js:433:3768)
    at Vo (kbn-ui-shared-deps-npm.dll.js:425:44978)
    at Uc (kbn-ui-shared-deps-npm.dll.js:425:105877)
    at wc (kbn-ui-shared-deps-npm.dll.js:425:96371)
    at kbn-ui-shared-deps-npm.dll.js:425:45201
    at t.unstable_runWithPriority (kbn-ui-shared-deps-npm.dll.js:433:3768)
data.plugin.js:1 Continue search session: last known search session id: "2cc00cd5-3156-4010-85b1-e7d8e078fe38", but received 5b2de4b6-6026-4fd4-9615-e2944505f03c
continue @ data.plugin.js:1
core.entry.js:1 Detected an unhandled Promise rejection.

        Message: Embeddable has been destroyed

        Stack: Error: Embeddable has been destroyed
    at visualize_embeddable_VisualizeEmbeddable.render (https://localhost:5601/68299/bundles/plugin/embeddable/1.0.0/embeddable.plugin.js:1:7542)
    at visualize_embeddable_VisualizeEmbeddable.render (https://localhost:5601/68299/bundles/plugin/visualizations/1.0.0/visualizations.chunk.10.js:1:9133)
    at https://localhost:5601/68299/bundles/plugin/embeddable/1.0.0/embeddable.chunk.2.js:1:9050
    at $c (https://localhost:5601/68299/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:425:106432)
    at t.unstable_runWithPriority (https://localhost:5601/68299/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:433:3768)
    at Vo (https://localhost:5601/68299/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:425:44978)
    at Uc (https://localhost:5601/68299/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:425:105877)
    at wc (https://localhost:5601/68299/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:425:96371)
    at https://localhost:5601/68299/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:425:45201
    at t.unstable_runWithPriority (https://localhost:5601/68299/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:433:3768)
embeddable.plugin.js:1 Uncaught (in promise) Error: Embeddable has been destroyed
    at visualize_embeddable_VisualizeEmbeddable.render (embeddable.plugin.js:1:7542)
    at visualize_embeddable_VisualizeEmbeddable.render (visualizations.chunk.10.js:1:9133)
    at embeddable.chunk.2.js:1:9050
    at $c (kbn-ui-shared-deps-npm.dll.js:425:106432)
    at t.unstable_runWithPriority (kbn-ui-shared-deps-npm.dll.js:433:3768)
    at Vo (kbn-ui-shared-deps-npm.dll.js:425:44978)
    at Uc (kbn-ui-shared-deps-npm.dll.js:425:105877)
    at wc (kbn-ui-shared-deps-npm.dll.js:425:96371)
    at kbn-ui-shared-deps-npm.dll.js:425:45201
    at t.unstable_runWithPriority (kbn-ui-shared-deps-npm.dll.js:433:3768)

Any additional context:

This is the loader that is showing in the broken panels

<div className="embPanel embPanel-isLoading">
<EuiLoadingChart size="l" mono />
</div>

@drewdaemon drewdaemon added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@drewdaemon
Copy link
Contributor Author

Possibly related to #150920

@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 8, 2023
@stratoula
Copy link
Contributor

Changing to low as refreshing the dashboard fixes everything.

@ThomThomson
Copy link
Contributor

Closing this issue for the time being, because customers will not encounter this issue.

@drewdaemon has the integrations team been able to use elastic-package edit dashboard to edit managed Dashboards? Does this happen every time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants