[Index Management] Fix enrich policies api test #172923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Index Management
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172697
Summary
Running an enrich policy is a long running task that might take x amount of time, in most cases should be pretty quick (depending on data) and in others it might take slightly longer. We have a timeout already in the execution step that catches most of these cases leaving us the delete enrich policy with the correct expected result that would be a 200. When the policy is still running the delete api will return a 429, with this PR we account for both scenarios in order for the test not to break.
I've also fixed the serverless functional tests for enrich policies that were failing for MKI, this seems to have happened due to the usage of a custom role.
I've run the PR on flaky-test-runner to make sure it all works as expected. Also ran them against MKI and seems to be passing too.