Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced Settings][Serverless] Fix functional tests #172846

Merged

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Dec 7, 2023

Fixes #172763
Fixes #172725

Summary

This PR fixes the flaky Advanced settings functional tests for serverless by increasing the sleep time and adding waitFor conditions.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4267

@ElenaStoeva ElenaStoeva self-assigned this Dec 7, 2023
@ElenaStoeva ElenaStoeva added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Dec 7, 2023
@ElenaStoeva ElenaStoeva marked this pull request as ready for review December 7, 2023 23:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@ElenaStoeva ElenaStoeva requested a review from a team December 7, 2023 23:32
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +6.4KB
securitySolutionServerless 354.8KB 361.1KB +6.3KB
total +12.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 42.0KB 42.0KB -1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks for patching this up @ElenaStoeva !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment