Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless Search] Index documents can be browsed in index management #172635

Merged
merged 4 commits into from
Dec 11, 2023
Merged

[Serverless Search] Index documents can be browsed in index management #172635

merged 4 commits into from
Dec 11, 2023

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented Dec 5, 2023 •
edited
Loading

This PR adds functionality to browse index documents in a index management app.

Screen Recording

browse.document.in.index.mmangement.page.mov

Checklist

Delete any items that are not applicable to this PR.

@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.12.0 labels Dec 5, 2023
@saarikabhasi saarikabhasi requested a review from a team December 5, 2023 21:08
TattdCodeMonkey
TattdCodeMonkey reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking good

...ck/plugins/serverless_search/public/application/components/index_documents/documents_tab.tsx Outdated Show resolved Hide resolved
x-pack/plugins/serverless_search/public/application/components/index_documents/documents.tsx Outdated Show resolved Hide resolved
x-pack/plugins/serverless_search/server/routes/indices_routes.ts Outdated
const from = page * size;

const searchResults = await fetchSearchResults(client, indexName, searchQuery, from, size);
// console.log('searchResults', from, size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left over

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, let me see if I can find any more of these

x-pack/plugins/serverless_search/server/routes/mapping_routes.ts Show resolved Hide resolved
x-pack/plugins/serverless_search/server/routes/indices_routes.ts Show resolved Hide resolved
@saarikabhasi
Copy link
Member Author

@elasticmachine merge upstream

@saarikabhasi
Copy link
Member Author

Note to reviewers:

05bfcd9d3161c31d078cad8cd34646b090ce5a7b is test commit to to confirm that Page load bundle size in this Post build CI error is dependent on the new package introduced in tsconfig.json. I will remove this commit once my testing is done.

@saarikabhasi saarikabhasi force-pushed the serverless/documents-can-browsed branch from 3b1d0e2 to c5c8af0 Compare December 11, 2023 15:06
@saarikabhasi saarikabhasi requested a review from a team as a code owner December 11, 2023 15:06
@saarikabhasi saarikabhasi force-pushed the serverless/documents-can-browsed branch from c5c8af0 to bd0562a Compare December 11, 2023 15:43
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSearch 301 326 +25

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.1MB 13.1MB +6.4KB
securitySolutionServerless 354.8KB 361.1KB +6.3KB
serverlessSearch 377.1KB 373.6KB -3.5KB
total +9.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 42.0KB 42.0KB -1.0B
serverlessSearch 54.0KB 71.1KB +17.1KB
total +17.1KB

History

  • 💔 Build #182861 failed 0b2f0a9784a0dc942fa4e5085b545becd5ccf459
  • 💔 Build #182806 failed be686929809b1e075314cf30184cc4db74c6cd39
  • 💔 Build #182793 failed be686929809b1e075314cf30184cc4db74c6cd39
  • 💔 Build #182611 failed 994d08a4f60d211a36f0862a85168b241dbf48bb
  • 💔 Build #182554 failed 2fcd5cf2da14b3ea54e38887f250107db6632345
  • 💔 Build #182021 failed cc243fb61f9fca5af8d5e8fe609044af023c2a11

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sphilipse
sphilipse approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saarikabhasi saarikabhasi merged commit 543a047 into elastic:main Dec 11, 2023
37 checks passed
@saarikabhasi saarikabhasi deleted the serverless/documents-can-browsed branch December 11, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey left review comments

@sphilipse sphilipse sphilipse approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saarikabhasi @kibana-ci @TattdCodeMonkey @jbudz @sphilipse @kibanamachine