Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review types in packages/kbn-failed-test-reporter-cli/failed_tests_reporter/add_messages_to_report.test.ts #172569

Closed
jbudz opened this issue Dec 5, 2023 · 2 comments
Closed

Review types in packages/kbn-failed-test-reporter-cli/failed_tests_reporter/add_messages_to_report.test.ts #172569

jbudz opened this issue Dec 5, 2023 · 2 comments
Labels
Team:Operations Team label for Operations Team

Comments

@jbudz
Copy link
Member

jbudz commented Dec 5, 2023

Adding the types/diff package in #172535 uncovered several type errors in tests. This is for addressing whether context needs to be included and snapshots should be updated and if there's any related issues.

Discussion: https://github.com/elastic/kibana/pull/172535/files#r1415526045
Build: https://buildkite.com/elastic/kibana-pull-request/builds/181627#018c381b-e3ae-4004-b1b6-9b78e11b530b
@jbudz jbudz added the Team:Operations Team label for Operations Team label Dec 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz mentioned this issue Dec 5, 2023
Merged
11 tasks
@jbudz
Copy link
Member Author

jbudz commented Jan 3, 2024

This was resolved in the linked PR.

@jbudz jbudz closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbudz @elasticmachine