Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] uncaught errors thrown during layer data fetching #172500

Closed
nreese opened this issue Dec 4, 2023 · 1 comment · Fixed by #172501
Closed

[maps] uncaught errors thrown during layer data fetching #172500

nreese opened this issue Dec 4, 2023 · 1 comment · Fixed by #172501
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Dec 4, 2023

Steps

  1. install web logs sample data
  2. open map
  3. add filter 
    {
  "error_query": {
    "indices": [
      {
        "error_type": "exception",
        "message": "local shard failure message 123",
        "name": "kibana_sample_data_logs"
      }
    ]
  }
}
  4. Open console and see uncaught error exeception. Error should not be uncaught since its displayed in map legend
Screenshot 2023-12-04 at 9 58 33 AM
@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Dec 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese mentioned this issue Dec 4, 2023
Merged
nreese added a commit that referenced this issue Dec 5, 2023
@nreese
[maps] fix uncaught errors thrown during layer data fetching (#172501)
06b026c 
Fixes #172500

PR resolves the issue by not re-throwing errors in GeoJsonVectorLayer
and MvtVectorLayer syncData methods. Error state is stored in data
request and displayed to users. Errors are thrown to stop the flow of
execution for syncData.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[maps] fix uncaught errors thrown during layer data fetching nreese/kibana
2 participants
@nreese @elasticmachine