Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared-ux] no-data analytics page package code cleanup #172416

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Dec 1, 2023

Summary

  1. Update "type" in kibana.jsonc files where applicable for improvement to developer experience.
  2. Create @kbn/content-management-table-list-view-table-common package and update imports

@tsullivan tsullivan self-assigned this Dec 1, 2023
@tsullivan tsullivan force-pushed the no-data/cleanup-i branch 2 times, most recently from 12d1c91 to b08890e Compare December 2, 2023 05:08
@tsullivan tsullivan marked this pull request as ready for review December 3, 2023 22:47
@tsullivan tsullivan requested review from a team as code owners December 3, 2023 22:47
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Dec 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan added the technical debt Improvement of the software architecture and operational architecture label Dec 3, 2023
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis team changes LGTM, code review only

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan tsullivan enabled auto-merge (squash) December 4, 2023 18:36
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/content-management-content-editor 4 8 +4
@kbn/content-management-tabbed-table-list-view 15 8 -7
@kbn/content-management-table-list-view 10 3 -7
@kbn/content-management-table-list-view-common - 7 +7
@kbn/content-management-table-list-view-table 41 34 -7
total -10

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/content-management-table-list-view-table 4 3 -1
Unknown metric groups

API count

id before after diff
@kbn/content-management-content-editor 6 10 +4
@kbn/content-management-tabbed-table-list-view 15 8 -7
@kbn/content-management-table-list-view 10 3 -7
@kbn/content-management-table-list-view-common - 7 +7
@kbn/content-management-table-list-view-table 59 52 -7
total -10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan

@tsullivan tsullivan merged commit f044bcc into elastic:main Dec 4, 2023
32 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 4, 2023
@tsullivan tsullivan deleted the no-data/cleanup-i branch December 4, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants