Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Add navigation to license if URL is configured #172404

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

demjened
Copy link
Contributor

@demjened demjened commented Dec 1, 2023

Summary

If a license page URL is configured for a (curated) model, the badge renders as clickable and navigates to the page in a new tab.
We are also adding the license link to the E5 model card.

Screenshot 2023-12-01 at 17 24 36

Checklist

@demjened demjened added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.12.0 labels Dec 1, 2023
@demjened demjened marked this pull request as ready for review December 1, 2023 22:27
@demjened demjened requested review from a team, Mikep86, kderusso and saikatsarkar056 December 1, 2023 22:27
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB +216.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

{licenseLabel}
</EuiLink>
) : (
<p>{licenseLabel}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this <p>? I'm not sure I've see this before, I have had to wrap <EuiBadge> with a <span> to ensure they dont grow in certain scenarios and wondering if this <p> solves that instead.

Copy link
Contributor Author

@demjened demjened Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TattdCodeMonkey {licenseLabel} by itself got recognized and reformatted as an object ({ licenseLabel }), and I used <p> a workaround. Is there an easier way, e.g. <>?

@demjened demjened merged commit c52cac9 into main Dec 4, 2023
@demjened demjened deleted the model-select-license-link branch December 4, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants