Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TableListView] Make managed content read-only #172387

Closed
Tracked by #172393
drewdaemon opened this issue Dec 1, 2023 · 3 comments · Fixed by #176263
Closed
Tracked by #172393

[TableListView] Make managed content read-only #172387

drewdaemon opened this issue Dec 1, 2023 · 3 comments · Fixed by #176263
Assignees
@drewdaemon
Labels
enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@drewdaemon
Copy link
Contributor

UI changes

  1. Managed content cannot be deleted from the table list view
  2. Managed content's metadata cannot be changed
image13
@drewdaemon drewdaemon added enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Dec 1, 2023
@drewdaemon drewdaemon self-assigned this Dec 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@drewdaemon drewdaemon mentioned this issue Dec 1, 2023
Closed
@vadimkibana
Copy link
Contributor

Hey, I see SharedUX tagged, is this something for use to take on or AX group will work on this?

@drewdaemon
Copy link
Contributor Author

Thanks for the question. I've assigned myself this issue. I plan to submit a contribution to your code as part of the larger project.

@drewdaemon drewdaemon mentioned this issue Feb 5, 2024
Merged
5 tasks
drewdaemon added a commit that referenced this issue Feb 8, 2024
@drewdaemon @kibanamachine @stratoula
[Managed content] readonly in library views (#176263)
1678780 
## Summary

Close #172387

This PR stops users from doing two things in the library views
1. deleting managed content
2. editing metadata of managed content

It also includes a refactor to the `TableListView` interface to replace
the `isItemEditable` callback with a row-level action.

<img width="1596" alt="Screenshot 2024-02-06 at 3 03 06 PM"
src="https://github.com/elastic/kibana/assets/315764/add84572-d4d7-4d69-baa8-a298a0ca7b83">

<img width="553" alt="Screenshot 2024-02-06 at 3 03 24 PM"
src="https://github.com/elastic/kibana/assets/315764/9bbdb6d5-a030-4c17-8f6d-daec4f5232a2">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — will be
completed in #175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed —
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5087
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@drewdaemon @kibanamachine
@stratoula @CoenWarmer
[Managed content] readonly in library views (elastic#176263)
934606d 
## Summary

Close elastic#172387

This PR stops users from doing two things in the library views
1. deleting managed content
2. editing metadata of managed content

It also includes a refactor to the `TableListView` interface to replace
the `isItemEditable` callback with a row-level action.

<img width="1596" alt="Screenshot 2024-02-06 at 3 03 06 PM"
src="https://github.com/elastic/kibana/assets/315764/add84572-d4d7-4d69-baa8-a298a0ca7b83">

<img width="553" alt="Screenshot 2024-02-06 at 3 03 24 PM"
src="https://github.com/elastic/kibana/assets/315764/9bbdb6d5-a030-4c17-8f6d-daec4f5232a2">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — will be
completed in elastic#175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed —
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5087
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@drewdaemon @kibanamachine
@stratoula @fkanout
[Managed content] readonly in library views (elastic#176263)
227e6d3 
## Summary

Close elastic#172387

This PR stops users from doing two things in the library views
1. deleting managed content
2. editing metadata of managed content

It also includes a refactor to the `TableListView` interface to replace
the `isItemEditable` callback with a row-level action.

<img width="1596" alt="Screenshot 2024-02-06 at 3 03 06 PM"
src="https://github.com/elastic/kibana/assets/315764/add84572-d4d7-4d69-baa8-a298a0ca7b83">

<img width="553" alt="Screenshot 2024-02-06 at 3 03 24 PM"
src="https://github.com/elastic/kibana/assets/315764/9bbdb6d5-a030-4c17-8f6d-daec4f5232a2">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — will be
completed in elastic#175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed —
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5087
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
@drewdaemon drewdaemon mentioned this issue Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewdaemon drewdaemon

Labels
enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Managed content] readonly in library views drewdaemon/kibana
3 participants
@drewdaemon @elasticmachine @vadimkibana