Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Log threshold alert details] Remove Technical Preview identifier #172379

Closed
2 tasks done
paulb-elastic opened this issue Dec 1, 2023 · 1 comment · Fixed by #172474 or #172554
Closed
2 tasks done

[Log threshold alert details] Remove Technical Preview identifier #172379

paulb-elastic opened this issue Dec 1, 2023 · 1 comment · Fixed by #172474 or #172554
Assignees
Labels
Team:obs-ux-management Observability Management User Experience Team v8.12.0

Comments

@paulb-elastic
Copy link
Contributor

paulb-elastic commented Dec 1, 2023

The alert details page for the Log threshold rule currently shows as Technical Preview, but this is no longer the case, so the labelling should be removed.

image

ACs:

  • Remove the TECHNICAL PREVIEW_ badge
  • Deprecate the feature flag (which is on by default): xpack.observability.unsafe.alertDetails.logs.enabled
@paulb-elastic paulb-elastic added the Team:obs-ux-management Observability Management User Experience Team label Dec 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@benakansara benakansara self-assigned this Dec 4, 2023
benakansara added a commit that referenced this issue Dec 5, 2023
#172474)

Partially resolves #172379

Removes "Technical Preview" and "Tell us what you think!" from the Log
threshold alert details page.

---------

Co-authored-by: Kibana Machine <[email protected]>
@benakansara benakansara reopened this Dec 5, 2023
benakansara added a commit that referenced this issue Dec 7, 2023
Resolves #172379

- Deprecates following feature flag used for enabling/disabling Log
threshold alert details page:
```
xpack.observability.unsafe.alertDetails.logs.enabled
```
- Removes usage of this flag from code.
- Adding this flag in `kibana.yml` will generate following warning:
```
[WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.alertDetails.logs.enabled".
```

---------

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 7, 2023
…172554)

Resolves elastic#172379

- Deprecates following feature flag used for enabling/disabling Log
threshold alert details page:
```
xpack.observability.unsafe.alertDetails.logs.enabled
```
- Removes usage of this flag from code.
- Adding this flag in `kibana.yml` will generate following warning:
```
[WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.alertDetails.logs.enabled".
```

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6628232)
kibanamachine referenced this issue Dec 7, 2023
…172554) (#172775)

# Backport

This will backport the following commits from `main` to `8.12`:
- [Deprecate feature flag for Log threshold alert details page
(#172554)](#172554)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-07T07:35:01Z","message":"Deprecate
feature flag for Log threshold alert details page (#172554)\n\nResolves
https://github.com/elastic/kibana/issues/172379\r\n\r\n- Deprecates
following feature flag used for enabling/disabling Log\r\nthreshold
alert details
page:\r\n```\r\nxpack.observability.unsafe.alertDetails.logs.enabled\r\n```\r\n-
Removes usage of this flag from code.\r\n- Adding this flag in
`kibana.yml` will generate following warning:\r\n```\r\n[WARN
][config.deprecation] You no longer need to configure
\"xpack.observability.unsafe.alertDetails.logs.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"6628232433c0144f7564b22d8e6d2941425431ae","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-management","v8.13.0"],"number":172554,"url":"https://github.com/elastic/kibana/pull/172554","mergeCommit":{"message":"Deprecate
feature flag for Log threshold alert details page (#172554)\n\nResolves
https://github.com/elastic/kibana/issues/172379\r\n\r\n- Deprecates
following feature flag used for enabling/disabling Log\r\nthreshold
alert details
page:\r\n```\r\nxpack.observability.unsafe.alertDetails.logs.enabled\r\n```\r\n-
Removes usage of this flag from code.\r\n- Adding this flag in
`kibana.yml` will generate following warning:\r\n```\r\n[WARN
][config.deprecation] You no longer need to configure
\"xpack.observability.unsafe.alertDetails.logs.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"6628232433c0144f7564b22d8e6d2941425431ae"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172554","number":172554,"mergeCommit":{"message":"Deprecate
feature flag for Log threshold alert details page (#172554)\n\nResolves
https://github.com/elastic/kibana/issues/172379\r\n\r\n- Deprecates
following feature flag used for enabling/disabling Log\r\nthreshold
alert details
page:\r\n```\r\nxpack.observability.unsafe.alertDetails.logs.enabled\r\n```\r\n-
Removes usage of this flag from code.\r\n- Adding this flag in
`kibana.yml` will generate following warning:\r\n```\r\n[WARN
][config.deprecation] You no longer need to configure
\"xpack.observability.unsafe.alertDetails.logs.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"6628232433c0144f7564b22d8e6d2941425431ae"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-management Observability Management User Experience Team v8.12.0
Projects
None yet
3 participants