Change pipeline selector dropdown to selection list #172330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
release_note:skip
Mikep86
requested review from
TattdCodeMonkey,
demjened,
kderusso and
a team
Mikep86
commented
Nov 30, 2023
| pipeline: MLInferencePipelineOption; | ||
| } | ||
|
|
||
| // TODO: Make disabledReason required and remove EXISTING_PIPELINE_DISABLED_MISSING_SOURCE_FIELDS call without args |
There was a problem hiding this comment.
This is here to serve as a reminder to address this in a separate tech debt PR
Mikep86
commented
Nov 30, 2023
| ); | ||
| }; | ||
|
|
||
| export const PipelineSelectOption: React.FC<PipelineSelectOptionProps> = ({ pipeline }) => { | ||
| const modelIdDisplay = pipeline.modelId.length > 0 ? pipeline.modelId : MODEL_REDACTED_VALUE; | ||
| return ( | ||
| <EuiFlexGroup direction="column" gutterSize="none"> | ||
| // TODO: Add model state & pipeline info link. Make sure to check mobile rendering when doing this! |
There was a problem hiding this comment.
Model state & pipeline info link was originally in scope, but was removed in the interest of meeting 8.12 FF. It will be added in a follow-up PR.
demjened
approved these changes
Nov 30, 2023
...ise_search_content/components/search_index/pipelines/ml_inference/pipeline_select_option.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Demjen <[email protected]>
...enterprise_search_content/components/search_index/pipelines/ml_inference/pipeline_select.tsx
Outdated
Show resolved
Hide resolved
...ise_search_content/components/search_index/pipelines/ml_inference/pipeline_select_option.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the "Add inference pipeline" flyout, change the existing pipeline selector dropdown to a selection list with search. Also re-organize the option layout to more closely match the layout implemented for ML pipeline cards in #172209.
Old:
New:
Checklist