-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Add section for _ignored field in dataset flyout #172265
Comments
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
I think we should display the number of times a specific field has been ignored. For example Like We should also cater for the situation where there are a lot of distinct ignored fields so that we can't necessarily list them all. |
I think it would be important to add a definition of what ignored fields are, so I'm calling for @mdbirnstiehl's input as well. Can we also add here why we are adding this section to the flyout and what is the value for the user, for future reference? I'd love for our issues descriptions to always include the reasoning behind it, so I can come in with the design/UX solution for discussion and the objectives are clear for everyone who reads this. cc @gbamparop @ruflin Question: Should users be able to take actions from these fields? Filtering by, for instance? |
The Actions on these fields are needed to jump to Logs Explorer and filter down on it, to see the exact documents that are affected. Later on, actions around jumping into a "fixing" flow will exist. It could go so far, that we directly offer them already a fix eventually 🪄 . There are different reasons why a field can end up in _ignore. We initially wanted to build each reason into Elasticsearch directly but to reduce scope, for now we are munging it all together into a single field. @felixbarny has some ideas how we could still take it apart. Assuming we can take it apart, it would be great to show a list for each reason:
How the different problems are solved is also different, so separating these is important. |
For the dataset quality page, we won't be able to determine the reason why a field has been ignored on aggregate. But I don't think that's a big issue. What matters most is which fields have been ignored, and how often. When clicking on an ignored field, it should take the user do the Logs explorer with a filter ( What's happening there should be defined in this issue: In short, we should list all ignored fields, their values, and the reason for why they have been ignored. |
If we would have the field reason, we could directly offer quick actions to the user directly from the dataset quality page fly out. For example, we see 25 of the ignored fields hit the field limit. We can group it and tell them a single fix to get rid of all of it. In the Log Explorere, users have to go through each document and figure out the reason per document and don't see the bigger picture. For now, all we can do is what Felix suggests but I think we put an unecessary burden on the user and should eventually improve it. |
…183934) ## Summary Closes #172265 ## Description This PR adds the Degraded Fields Table to the Dataset Quality Flyout for individual Data Stream. Following tasks were done as part of this PR 1. A new server side endpoint created which queries the `datastream` directly and aggregates `_ignored` fields for that data stream during the given time range and also adds a sub aggregation for last occurence. 2. On the UI Side, the table was added with 3 columns as mentioned in the Original ticket - Field, Count and Last Occurrence 3. The UI currently supports clients side sorting and pagination. We can move this to server side pagination sorting if required in the future. 4. The Flyout also supports sync with the URL which means user can navigate to the Dataset Quality page where the flyout would be open and Sorting and Pagination would be pre-applied 5. API Tests 6. Stateful and Serverless FTR tests ## Screenshot <img width="1278" alt="image" src="https://github.com/elastic/kibana/assets/7416358/36a9b5cd-de05-4d17-99a2-cc08ec4583dd"> ## Scenario 1. Spin up a 8.14-snapshot instance 2. Ingest degraded docs 3. Upgrade to 8.15-snapshot 4. Open Data Set Quality Flyout and see how the page looks like <img width="1286" alt="image" src="https://github.com/elastic/kibana/assets/7416358/100f3c8c-b697-4f81-ac7e-427d0f468407">
Latest designs can be found in this Figma file with related comments and details :) |
📓 Summary
Allow users to get an overview of the fields that are inside
_ignored
property in their dataset.For iteration 1, we will display this table in the DQ Flyout.
✔️ Acceptance criteria
_ignored
fields in the dataset.Other columns displayed in the image are out of scope for this ticket.
The text was updated successfully, but these errors were encountered: