Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing ES Promotion: FTR Configs #77 / discover/group2 discover data grid field tokens should render field tokens correctly for ES|QL #172243

Closed
mistic opened this issue Nov 30, 2023 · 2 comments · Fixed by #172220
Closed

Failing ES Promotion: FTR Configs #77 / discover/group2 discover data grid field tokens should render field tokens correctly for ES|QL #172243

mistic opened this issue Nov 30, 2023 · 2 comments · Fixed by #172220
Labels
failed-es-promotion Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@mistic
Copy link
Member

mistic commented Nov 30, 2023

Chrome UI Functional Tests
test/functional/apps/discover/group2/_data_grid_field_tokens.ts

discover/group2 discover data grid field tokens should render field tokens correctly for ES|QL

This failure is preventing the promotion of the current Elasticsearch snapshot.

For more information on the Elasticsearch snapshot process including how to reproduce using the unverified ES build please read the failed promotion annotation. Other important information can be found at:

TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="unifiedHistogramQueryHits"])
Wait timed out after 10046ms
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-83d2d8869733d1aa/elastic/kibana-elasticsearch-snapshot-verify/kibana/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at processTicksAndRejections (node:internal/process/task_queues:95:5) {
  remoteStacktrace: ''
}
@mistic mistic added blocker skipped-test failed-es-promotion Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0 labels Nov 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

mistic added a commit that referenced this issue Nov 30, 2023
@mistic
skip failing es promotion suites (#172243)
f1ac914
@mistic
Copy link
Member Author

mistic commented Nov 30, 2023

Skipped.

main: f1ac914

@davismcphee davismcphee mentioned this issue Nov 30, 2023
Merged
9 tasks
stratoula pushed a commit that referenced this issue Nov 30, 2023
@davismcphee
[ES|QL] Remove use of time_zone param in ES|QL requests (#172220)
f89c6fd 
## Summary

Support for the `time_zone` request param was temporarily removed from
ES|QL in elastic/elasticsearch#102767. This
caused some of our tests to fail since we include the `time_zone` param
in ES|QL requests in Kibana. This PR comments out the `time_zone`
related code until support is reintroduced in ES|QL, and unskips the
broken tests.

The followup work to uncomment the code when `time_zone` support is
reintroduced to ES|QL will be done in #172221.

Resolves #172215.
Resolves #172213.
Resolves #172242.
Resolves #172243.
Resolves #172244.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failed-es-promotion Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Remove use of time_zone param in ES|QL requests davismcphee/kibana
3 participants
@mistic @elasticmachine @kibanamachine