Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSquery]when we are running a saved query it's timeout field time changed to default time (60s) #172138

Closed
sukhwindersingh-qasource opened this issue Nov 29, 2023 · 14 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 v8.12.1

Comments

@sukhwindersingh-qasource

Describe the bug:
when we are running a saved query it's timeout field time changed to default time (60s)

Build Details:

VERSION: 8.12.0
BUILD: 69418
COMMIT: a4aa7117bb04d6ded121237ca7d2cd77c9f93ceb

Preconditions

  • Kibana should be running.
  • Agent with Osquery manager integration should be installed.
  • Saved query should be saved with timeout field value as 600s

Steps to Reproduce

  • Navigate to Osquery > Saved queries
  • Now click on run button of the saved query mentioned in the preconditions
  • Observe when we are running a saved query it's timeout field time changed to default time (60s), Instead of the time we have configured while we saved the query.

Actual result

  • when we are running a saved query it's timeout field time changed to default time (60s), Instead of the time we have configured while we saved the query.

Expected Result

  • when we are running a saved query it's timeout field time should remain same as we have configured while we saved the query

Screen-Cast

Saved.queries.-.Osquery.-.Elastic.Mozilla.Firefox.2023-11-29.14-48-20.mp4
@sukhwindersingh-qasource sukhwindersingh-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0 labels Nov 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@sukhwindersingh-qasource
Copy link
Author

@muskangulati-qasource kindly review
Thanks!

@muskangulati-qasource
Copy link

Reviewed and assigned to @kevinlog

@szwarckonrad
Copy link
Contributor

Further investigation:
Happens only when running saved query using "play" button, choosing saved query in live query view prevails the timeout.

Screen.Recording.2023-12-01.at.10.15.33.mov

szwarckonrad added a commit that referenced this issue Dec 6, 2023
#172138

Clicking "play" button on saved queries list didn't properly transfer
`timeout` field through url change.



https://github.com/elastic/kibana/assets/29123534/4ec184a9-567f-4cc7-8b7b-a0985f2be811
@szwarckonrad
Copy link
Contributor

Merged to main with 8.12 label.

@szwarckonrad szwarckonrad added the QA:Ready for Testing Code is merged and ready for QA to validate label Dec 6, 2023
@nicpenning
Copy link

Any idea if this is related to OS Query not having a controllable timeout functionality?

https://elasticstack.slack.com/archives/CNEDGGJQ3/p1701811075074549?thread_ts=1701811075.074549&cid=CNEDGGJQ3

@kevinlog
Copy link
Contributor

kevinlog commented Dec 8, 2023

@sukhwindersingh-qasource this is ready for testing in 8.12 BC or latest snapshot

@szwarckonrad
Copy link
Contributor

szwarckonrad commented Dec 8, 2023

@nicpenning

This PR is about a configurable Timeout field when running or scheduling Osquery query. This functionality will be introduced with 8.12 release. It is not related to the long running queries reported in Community Slack. Thanks for keeping an eye out though 🙏

@sukhwindersingh-qasource
Copy link
Author

Hi @szwarckonrad

We have validated this ticket on the latest **8.12.0 ** build and found the issue is FIXED. ✔️
But We have also observed that timeout is also not included in Live query run. ❌

Please find below the testing details

Build Details:

VERSION: 8.12.0 BC3
BUILD: 69985
COMMIT: 2a8afed

Screen Recording:
Run from saved query: ✔️

Saved.queries.-.Osquery.-.Elastic.Mozilla.Firefox.2023-12-27.16-42-30.mp4

Run from Live query: ❌

Live.queries.-.Osquery.-.Elastic.Mozilla.Firefox.2023-12-27.16-39-21.mp4

Please let us know if anything else is required from our end.

Thanks!!

@dasansol92
Copy link
Contributor

Hey @sukhwindersingh-qasource , is the live query behaviour the same as before the changes or is the behaviour different because the latest changes? Just want to make sure if this is a 8.12 regression or not. Thanks!
cc: @szwarckonrad

@sukhwindersingh-qasource
Copy link
Author

sukhwindersingh-qasource commented Dec 28, 2023

Hi @dasansol92

Behaviour of Live query is same as before this is only related to the Timeout field value as when we click on the Run button of live query. Then the timeout fields value is auto set to 60s , But it should be remain as the earlier value while we run the query.

Screen-Cast

New.-.Live.queries.-.Osquery.-.Elastic.Mozilla.Firefox.2023-12-28.11-26-55.mp4

Please do let us know if anything else is required from our end.
Thanks!

@sukhwindersingh-qasource
Copy link
Author

Closing this Ticket and marking it as QA Validated as it is fixed Opened a new ticket for the additional observation shared #174082

@sukhwindersingh-qasource sukhwindersingh-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jan 2, 2024
@sukhwindersingh-qasource
Copy link
Author

Bug Conversion

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 v8.12.1
Projects
None yet
Development

No branches or pull requests

7 participants