Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize new/existing pipeline management screens into tabs #172027

Merged
merged 7 commits into from
Nov 28, 2023

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Nov 27, 2023

Summary

Split Configure step’s components in pipeline creation into two tabs:

  • Create new: pipeline name, model selection
  • Use existing: pipeline selection

Keep the split components' content as-is, they are out of scope for this task.

Remove the left hand side panels (“Create or select a pipeline”, “Select a trained ML Model” and blurbs underneath), and make the tab full width.

Also remove the ELSER text expansion callout from the flyout.

Screenshot 2023-11-28 at 9 25 58 AM

Screenshot 2023-11-28 at 9 26 22 AM

Checklist

For maintainers

@Mikep86 Mikep86 added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Nov 27, 2023
@Mikep86 Mikep86 requested review from demjened, kderusso and a team November 27, 2023 21:55
@Mikep86 Mikep86 added release_note:enhancement backport:skip This commit does not require backporting and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 27, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB -1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please add team label too. Also you don't need backport:skip all you need is version labels. CI will figure backports from them.

@Mikep86 Mikep86 removed the backport:skip This commit does not require backporting label Nov 28, 2023
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@demjened demjened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mikep86 Mikep86 added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Nov 28, 2023
@Mikep86 Mikep86 merged commit e94a977 into elastic:main Nov 28, 2023
8 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants