[Console] Fix wrong autocomplete suggestions on typing in slash #171948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakurai-youhei
added
bug
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
yuliacech
added
the
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
yuliacech
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Thanks a lot, @sakurai-youhei! Tested locally and changes LGTM 👍
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2023
…tic#171948) Closes elastic#171947 ## Summary This PR fixes wrong autocomplete suggestions on typing in slash in some specific cases.  ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes wrong autocomplete suggestions on typing in slash (cherry picked from commit 11136b6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2023
#171948) (#172177) # Backport This will backport the following commits from `main` to `8.11`: - [[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)](#171948) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Youhei Sakurai","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-29T14:22:40Z","message":"[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)\n\nCloses #171947\r\n\r\n## Summary\r\n\r\nThis PR fixes wrong autocomplete suggestions on typing in slash in some\r\nspecific cases.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes wrong autocomplete suggestions on typing in slash","sha":"11136b688061fd3f4914915ea0da6e3917b5e66b","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Console","release_note:fix","Team:Deployment Management","backport:prev-minor","v8.12.0"],"number":171948,"url":"https://github.com/elastic/kibana/pull/171948","mergeCommit":{"message":"[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)\n\nCloses #171947\r\n\r\n## Summary\r\n\r\nThis PR fixes wrong autocomplete suggestions on typing in slash in some\r\nspecific cases.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes wrong autocomplete suggestions on typing in slash","sha":"11136b688061fd3f4914915ea0da6e3917b5e66b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171948","number":171948,"mergeCommit":{"message":"[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)\n\nCloses #171947\r\n\r\n## Summary\r\n\r\nThis PR fixes wrong autocomplete suggestions on typing in slash in some\r\nspecific cases.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes wrong autocomplete suggestions on typing in slash","sha":"11136b688061fd3f4914915ea0da6e3917b5e66b"}}]}] BACKPORT--> Co-authored-by: Youhei Sakurai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171947
Summary
This PR fixes wrong autocomplete suggestions on typing in slash in some specific cases.
For maintainers
Release note
Fixes wrong autocomplete suggestions on typing in slash