[Console] url.slash behaves like url.comma on autocomplete #171947
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Console
Dev Tools Console Feature
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Comments
sakurai-youhei
added
bug
sakurai-youhei
added a commit
to sakurai-youhei/kibana
that referenced
this issue
Nov 25, 2023
1 task
yuliacech
added
the
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
sakurai-youhei
added a commit
that referenced
this issue
Nov 29, 2023
) Closes #171947 ## Summary This PR fixes wrong autocomplete suggestions on typing in slash in some specific cases.  ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes wrong autocomplete suggestions on typing in slash
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 29, 2023
…tic#171948) Closes elastic#171947 ## Summary This PR fixes wrong autocomplete suggestions on typing in slash in some specific cases.  ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes wrong autocomplete suggestions on typing in slash (cherry picked from commit 11136b6)
kibanamachine
added a commit
that referenced
this issue
Nov 29, 2023
#171948) (#172177) # Backport This will backport the following commits from `main` to `8.11`: - [[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)](#171948) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Youhei Sakurai","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-29T14:22:40Z","message":"[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)\n\nCloses #171947\r\n\r\n## Summary\r\n\r\nThis PR fixes wrong autocomplete suggestions on typing in slash in some\r\nspecific cases.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes wrong autocomplete suggestions on typing in slash","sha":"11136b688061fd3f4914915ea0da6e3917b5e66b","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Console","release_note:fix","Team:Deployment Management","backport:prev-minor","v8.12.0"],"number":171948,"url":"https://github.com/elastic/kibana/pull/171948","mergeCommit":{"message":"[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)\n\nCloses #171947\r\n\r\n## Summary\r\n\r\nThis PR fixes wrong autocomplete suggestions on typing in slash in some\r\nspecific cases.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes wrong autocomplete suggestions on typing in slash","sha":"11136b688061fd3f4914915ea0da6e3917b5e66b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171948","number":171948,"mergeCommit":{"message":"[Console] Fix wrong autocomplete suggestions on typing in slash (#171948)\n\nCloses #171947\r\n\r\n## Summary\r\n\r\nThis PR fixes wrong autocomplete suggestions on typing in slash in some\r\nspecific cases.\r\n\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nFixes wrong autocomplete suggestions on typing in slash","sha":"11136b688061fd3f4914915ea0da6e3917b5e66b"}}]}] BACKPORT--> Co-authored-by: Youhei Sakurai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version:
8.11.1
Elasticsearch version:
8.11.1
Server OS version:
Elastic Cloud
Browser version:
Google Chrome 119.0.6045.160（Official Build） （64 bit）
Browser OS version:
Windows 10.0.19045
Original install method (e.g. download page, yum, from source, etc.):
Elastic Cloud
Describe the bug:
Because #164608 doesn't check the token on the current position, typing in
/(slash) may result in inappropriate autocomplete suggestions in some specific cases.Steps to reproduce:
GET .security,..kibanaadditionally./-> still suggests indices.Expected behavior:
Autocomplete should suggest API endpoints such as
_searchat step 5.Screenshots (if relevant):
Errors in browser console (if relevant):
Provide logs and/or server output (if relevant):
Any additional context:
The text was updated successfully, but these errors were encountered: