AI Assistant Management Plugin + Knowledge Base Management #171933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stant-settings-page
…stant-settings-page
…stant-settings-page
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
CoenWarmer
added
the
release_note:skip
…armer/kibana into feat/obs-aiassistant-settings-page
…armer/kibana into feat/obs-aiassistant-settings-page
…stant-settings-page
…armer/kibana into feat/obs-aiassistant-settings-page
…stant-settings-page
…stant-settings-page
CoenWarmer
force-pushed
the
feat/obs-aiassistant-settings-page
branch
from
ac741c8 to
e4a86ad
Compare
CoenWarmer
commented
Dec 4, 2023
| } | ||
| if ( | ||
| category.entries.length === 1 && | ||
| category.entries[0].role === 'assistant_summarization' |
There was a problem hiding this comment.
If you are wondering, 'why not use the enum from Obs AI Assistant?'
Module not found: Error: import [@kbn/observability-ai-assistant-plugin/public] references a public export of the [observabilityAIAssistant] bundle, but that bundle is not in the "requiredPlugins" or "requiredBundles" list in the plugin manifest [/Users/coenwarmer/Dev/kibana2/src/plugins/ai_assistant_management/observability/kibana.jsonc]
and due to OSS plugins not being able to require xpack plugins, the plugin can't be included in requiredPlugins
dgieselaar
approved these changes
Dec 5, 2023
|
@elasticmachine merge upstream |
CoenWarmer
force-pushed
the
feat/obs-aiassistant-settings-page
branch
from
3ed5869 to
e99b539
Compare
💔 Build FailedFailed CI Steps
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Merging now. Synthetics tests are failing upstream - see https://buildkite.com/elastic/kibana-on-merge-unsupported-ftrs/builds?branch=main. If there's any concerns please reach out. |
kibanamachine
added
v8.12.0
backport:skip
10 tasks
justinkambic
added a commit
that referenced
this pull request
Dec 6, 2023
## Summary Recently, #171933 introduced a notion of `QueryClientProvider` to observability. It seems like we might need to include this also in our rule wrapper, as it is perhaps rendered outside of the tree in question and doesn't play nice, perhaps as a result of lazy loading. Strangely I cannot repro this failure locally. Here's an example build failure though: https://buildkite.com/elastic/kibana-pull-request/builds/182158#018c3f75-d7c8-42a6-ac6c-0c30f66fe54c ~This initial patch might not resolve the issue, in which case I'll ping others to assist.~ This seems to have un-broken the tests. ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
paulb-elastic
added
Team:Uptime - DEPRECATED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a bunch of plugins to help manage AI Assistant Management settings.
It offers a 'selection' plugin inside Stack Management where a user can select which AI Assistant she wants to manage.
The Security team can hook into this one, so settings for both AI Assistants can be accessed from inside one place inside Stack Management.
This PR also adds the plugin to manage settings for the AI Assistant for Observability, including Knowledge Base management. This plugin is available both in Stack Management (stateful) and Project Settings (serverless).
What it looks like
Screen.Recording.2023-11-24.at.17.17.09_high.mov
Detailed
Adds a Stack Management plugin (
/src/plugins/ai_assistant_management/selection). Its primary function is to render a selection screen to help users navigate to the settings plugin for the AI Assistant for a specific solution. This plugin is displayed in Stack Management, which is only available in stateful versions of Kibana.Adds a AI Assistant for Observability Settings plugin (
/src/plugins/ai_assistant_management/observability). This plugin allows management of specific Observability AI Assistant settings. It is available in stateful versions of Kibana (via the aforementioned Stack Management plugin) or in serverless versions via Project Management.Knowledge Base management for Observability AI Assistant: The AI Assistant for Observability Settings plugin has a Knowledge Base tab, which allows users to add / read / update / delete and bulk import entries into the Knowledge Base of the Observability AI Assistant.
Moving of KB endpoints in Observability AI Assistant plugin: KB endpoints and functions were located in the same folder. As this PR adds new endpoints for the KB for CRUD operations, it also moves the existing ones from the function folder into a dedicated one so there's a clearer distinction between kb and functions.
Adding of GenAI Connector inside Chat Flyout: If the user has admin rights, it is possible to set up a GenAI connector from within the Observability AI Assistant Chat Flyout. This provides a faster and more seamless onboarding experience. If the user does not, she will be redirected to the Settings page.
Bug fixes
How to test
app/management/kibana/aiAssistantManagementObservability?tab=knowledge_base)Todo