Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Add test coverage for Alert User Assignment (#171307) #171930

Merged
merged 4 commits into from
Nov 27, 2023
Merged

[Security Solution][Detections] Add test coverage for Alert User Assignment (#171307) #171930

merged 4 commits into from
Nov 27, 2023

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Nov 24, 2023

Summary

Addresses #171307

This PR adds tests overage according to this test plans #171306

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Nov 24, 2023
@e40pud e40pud self-assigned this Nov 24, 2023
@e40pud e40pud requested review from a team as code owners November 24, 2023 15:34
@e40pud e40pud requested a review from WafaaNasr November 24, 2023 15:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud
Merge branch 'security/feature/alert-user-assignment' into security/f…
daa327f 
…eature/alert-user-assignment-tests

# Conflicts:
#	x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts/alert_assignees.cy.ts
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #2 / Correlation tab should update timeline after removing eql should update timeline after removing eql

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4760 4762 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +409.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count 5655 - -5655
total size 5.9MB - -5.9MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@e40pud e40pud requested a review from MadameSheema November 27, 2023 10:26
@e40pud e40pud merged commit e317182 into elastic:security/feature/alert-user-assignment Nov 27, 2023
1 check passed
@e40pud e40pud deleted the security/feature/alert-user-assignment-tests branch November 27, 2023 11:02
@e40pud e40pud mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero left review comments

@WafaaNasr WafaaNasr Awaiting requested review from WafaaNasr WafaaNasr was automatically assigned from elastic/security-detection-engine

@MadameSheema MadameSheema Awaiting requested review from MadameSheema

Assignees

@e40pud e40pud

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e40pud @elasticmachine @kibana-ci @yctercero