[ML] [AIOps] Log Rate Analysis: Shows top N results when no docs in baseline or deviation #171924
Conversation
walterra
added
release_note:enhancement
:ml
Feature:ML/AIOps
|
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_type_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_type_callout.tsx
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| if (version === '2') { |
There was a problem hiding this comment.
Version 1 and 2 look pretty much identical here - is this duplication purely for type reasons?
There was a problem hiding this comment.
Just a small difference, version 1 is accessing significantTerms whereas version 2 uses significantItems.
| import { getQueryWithParams } from './get_query_with_params'; | ||
| import { getRequestBase } from './get_request_base'; | ||
|
|
||
| // TODO Consolidate with duplicate `fetchDurationFieldCandidates` in |
There was a problem hiding this comment.
Is this comment still needed?
There was a problem hiding this comment.
Yes, this is an older comment I copied over, it's related to this issue where we track potential cleanups of duplicated code: #136182
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
szabosteve
changed the title
Summary
Resolves #169767.
This PR adds a fallback analysis when either the baseline or deviation time range contains no documents. Instead of trying to fetch significant items (which would return no results), this will just fetch the top terms/categories for the time range that has some documents.
Analysis type: Top items for deviation time range when no docs in baseline
Analysis type: Top items for baseline time range when no docs in deviation
Checklist