[Custom Threshold Rule] Fix custom threshold deletion/update

[shahzad31]

Summary

Fix custom threshold deletion/update !!

Set id in expression items to make sure uniqueness

Fixes #171623

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: ea80f1c

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observability	1.1MB	1.1MB	+251.0B

History

• 💔 Build #178785 failed 21fc80a
• 💔 Build #178774 failed ec6cc3b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[maryam-saeidi]

I checked metric threshold and we don't have this issue there, can we use a similar approach without adding an id to the rule's saved object and API? Since rule creation API is used by SRE, I rather not add extra fields there if it is not necessary.

Screen.Recording.2023-11-27.at.08.23.52.mov

[maryam-saeidi]

With this change, we are adding an id to the rule's saved object and our create/update API just for using it in UI, which I don't think is a good idea. Can we handle it only on the UI side without adding a field to the rule's saved object?

[shahzad31]

id is only used in UI and isn't a required field when let's say user is using an API.

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[maryam-saeidi]

@shahzad31 I noticed that the issue only happens for the aggregation and equation section and I fixed it by making sure these sections will re-render if deletion happens. Here is the fix: #172187

[shahzad31]

closing in favor of #172187