[Serverless] Improve stability of prod quality gate SLO check #171917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @watson |
kobelb
approved these changes
Nov 27, 2023
jbudz
approved these changes
Nov 27, 2023
lukeelmers
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a recent discussion with @kobelb I'm changing the SLO check that's currently running during a serverless promotion in
Production-CanaryandProduction-NonCanary.Before this change we relied on the default values of these settings, which are quite "aggressive":
CHECK_SLO_WAITING_PERIOD- Due to the relatively low amount of deployments in these environments, we suspect it would be a good idea to increase this value from the default5mto15m.CHECK_SLO_BURN_RATE_THRESHOLD- The default value is0, which leaves absolutely no room for even the smallest hiccup. Setting to0.1to avoid this.We can always update this in the future once we start to get more deployments in these environments.