Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Ensure compatibility with data view caching #171389

Open
weltenwort opened this issue Nov 16, 2023 · 6 comments
Open

[Logs Explorer] Ensure compatibility with data view caching #171389

weltenwort opened this issue Nov 16, 2023 · 6 comments
Labels
Team:obs-ux-logs Observability Logs User Experience Team

Comments

@weltenwort
Copy link
Member

weltenwort commented Nov 16, 2023

📓 Summary

#168910 adds caching of the field list to data views. When on-boarding new datasets we rely on new data becoming available, so we need to ensure the cache doesn't break that. We should also consider adding a means for the user to manually invalidate the cache.

✔️ Acceptance criteria

  • The data view caching doesn't break the on-boarding flow.
  • There is a way for the user to manually refresh the field list.

🎨 Mock-ups

🚧 TODO

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 16, 2023
@weltenwort
Copy link
Member Author

@isaclfreire could you please help us with mock-ups for the manual field refresh? 😇

@weltenwort weltenwort added the Team:obs-ux-logs Observability Logs User Experience Team label Nov 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 16, 2023
@kertal
Copy link
Member

kertal commented Feb 7, 2024

QQ: ist this still needed? UnifiedFieldList takes care of automatically adding new fields and also refreshing the cached data view in this case, it was merged recently, and this issue was created in November, so maybe this is already resolved?

PR #172329

@gbamparop
Copy link
Contributor

Hi @kertal, this issue is mostly to double check that the changes introduced by #172329 work as expected with logs explorer. We might add some automated tests for some cases too.

@thomheymann
Copy link
Contributor

@weltenwort Does this issue #172329 resolve your concerns around refreshing fields or do we still require a manual refresh button? Could you also let me know what the dataset onboarding flow is you mention so that I can verify whether this works as expected?

@thomheymann
Copy link
Contributor

I have tested the boarding flow locally. New dataset and its fields show up correctly as part of the onboarding journey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

No branches or pull requests

5 participants