-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps] Require all
privilege to "Actions and Connectors" in order to execute SentinelOne sub-actions
#171247
[ResponseOps] Require all
privilege to "Actions and Connectors" in order to execute SentinelOne sub-actions
#171247
Conversation
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
buildkite test this |
1 similar comment
buildkite test this |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM but I noticed the UI doesn't reflect the updated RBAC changes:
- "Run this connector" button in the connectors list is still visible for SentinelOne connector when the user is read only
- "Test" tab is visible when opening the connector flyout for a read only user
- SentinelOne connector shows up as an action to alerting rules when user is read only
We'll need these bugs fixed before a EDR connector becomes GA. Is this something you would like to fix in this PR or would like to defer to a later time? We can provide code pointers.
Summary
all
privilege to "Actions and Connectors"Testing
In order to test this change the SentinelOne connector needs to be enabled by setting the following config property:
Checklist