Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metric threshold] Incorrect rule params when changing nonCount agg to count in custom equation #171088

Closed
maryam-saeidi opened this issue Nov 13, 2023 · 1 comment · Fixed by #171958
Closed

[Metric threshold] Incorrect rule params when changing nonCount agg to count in custom equation #171088

maryam-saeidi opened this issue Nov 13, 2023 · 1 comment · Fixed by #171958
Assignees
@maryam-saeidi
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team v8.12.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Nov 13, 2023 •
edited
Loading

📝 Summary

As shown below, in the custom agg, field data is included in count aggregation when changing from nonCount agg with a field name to count. This will cause a validation error as count agg does not have a field param.

Screen.Recording.2023-11-13.at.14.08.09.mov

✅ Acceptance Criteria

  • Fix the above bug similar to the fix for the custom threshold rule (here)
  • Add test if possible
@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience v8.12.0 Team:obs-ux-management Observability Management User Experience Team labels Nov 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi changed the title [Metric threshold] Incorrect data when changing nonCount agg to count in custom equation [Metric threshold] Incorrect rule params when changing nonCount agg to count in custom equation Nov 13, 2023
@maryam-saeidi maryam-saeidi mentioned this issue Nov 27, 2023
Merged
maryam-saeidi added a commit that referenced this issue Dec 4, 2023
@maryam-saeidi
[Metric threshold] Fix incorrect rule params when changing nonCount a…
fd836e8 
…gg to count in custom equation (#171958)

Closes #171088

## Summary

This PR fixes the incorrect params when changing aggregation from
nonCount to count:


https://github.com/elastic/kibana/assets/12370520/56ae5612-e254-4815-98fa-e773cbe4ba38

I didn't find an easy way to add a test for this case, as this is a
minor UI issue. It is worth mentioning that the metric threshold rule
will be deprecated eventually. Let me know if you have any suggestions
for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-management Observability Management User Experience Team v8.12.0
Projects
None yet
Milestone
No milestone
2 participants
@maryam-saeidi @elasticmachine