Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security][FTR]Fix for flaky add integration FTR #171053

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[Cloud Security][FTR]Fix for flaky add integration FTR #171053

merged 2 commits into from
Nov 13, 2023

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Nov 10, 2023 •
edited
Loading

@animehart animehart changed the title fix for somewhat flaky ftr [Cloud Security][FTR]Fix for flaky add integration FTR Nov 11, 2023
@animehart animehart added v8.12.0 Team:Cloud Security Cloud Security team related release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 11, 2023
@animehart animehart marked this pull request as ready for review November 11, 2023 07:41
@animehart animehart requested a review from a team as a code owner November 11, 2023 07:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This was linked to issues Nov 12, 2023
Failing test: X-Pack Cloud Security Posture Functional Tests.x-pack/test/cloud_security_posture_functional/pages/cis_integration·ts - Cloud Security Posture Test adding Cloud Security Posture Integrations CIS_AWS On Add Agent modal there should be modal that has Cloud Formation details as well as button that redirects user to Cloud formation page on AWS upon clicking them #170886
Closed
Failing test: X-Pack Cloud Security Posture Functional Tests.x-pack/test/cloud_security_posture_functional/pages/cis_integration·ts - Cloud Security Posture Test adding Cloud Security Posture Integrations CIS_GCP Single Users are able to switch credentials_type from/to Credential JSON fields #170633
Closed
Failing test: X-Pack Cloud Security Posture Functional Tests.x-pack/test/cloud_security_posture_functional/pages/cis_integration·ts - Cloud Security Posture Test adding Cloud Security Posture Integrations CIS_GCP Single Users are able to switch credentials_type from/to Credential File fields #171050
Closed
maxcold
maxcold approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at the failures it seems like shouldLoginIfPrompted isn't really affecting the tests. Or am I missing smth? If that's the case, I'd only leave ensureCurrentUrl change, to not confuse ourselves in the future

@animehart animehart merged commit 49b4882 into elastic:main Nov 13, 2023
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
@animehart animehart removed a link to an issue Jan 24, 2024
Failing test: X-Pack Cloud Security Posture Functional Tests.x-pack/test/cloud_security_posture_functional/pages/cis_integration·ts - Cloud Security Posture Test adding Cloud Security Posture Integrations CIS_GCP Single Users are able to switch credentials_type from/to Credential JSON fields #170633
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcold maxcold maxcold approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.12.0
Projects
None yet
Milestone
No milestone
4 participants
@animehart @elasticmachine @kibana-ci @maxcold