FullStory: Skip setup for Elasticians #171041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @afharo |
pgayvallet
approved these changes
Nov 13, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 13, 2023
(cherry picked from commit 19da2d5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 13, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [FullStory: Skip setup for Elasticians (#171041)](#171041) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-13T14:14:23Z","message":"FullStory: Skip setup for Elasticians (#171041)","sha":"19da2d527686b329b53aba0320ff8b1b1c0cd7fe","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Telemetry","release_note:skip","telemetry","backport:prev-minor","Team:Journey/Onboarding","v8.12.0"],"number":171041,"url":"https://github.com/elastic/kibana/pull/171041","mergeCommit":{"message":"FullStory: Skip setup for Elasticians (#171041)","sha":"19da2d527686b329b53aba0320ff8b1b1c0cd7fe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171041","number":171041,"mergeCommit":{"message":"FullStory: Skip setup for Elasticians (#171041)","sha":"19da2d527686b329b53aba0320ff8b1b1c0cd7fe"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
|
This PR haven't made it into the latest BC of 8.11.1. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To save some sessions coming from Elasticians, we want to disable FullStory for any deployments owned by Elastic employees.
cc @shahinakmal @bollinic
Planning to backport this to the previous minor so we have it live asap.
Checklist
Delete any items that are not applicable to this PR.
For maintainers