-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless Search] Update Getting Ingest Data section #171035
[Serverless Search] Update Getting Ingest Data section #171035
Conversation
6dbe2e1
to
b4bc358
Compare
@elasticmachine merge upstream |
f17274d
to
b8e985b
Compare
x-pack/plugins/serverless_search/public/application/components/overview.tsx
Outdated
Show resolved
Hide resolved
b8e985b
to
e177582
Compare
@saarikabhasi did you test that these changes don't effect dedicated? I don't think the |
@TattdCodeMonkey I did a quick search for https://github.com/search?q=repo%3Aelastic%2Fkibana%20IntegrationsPanel&type=code |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, but we need to address some structural issues with Serverless vs Dedicated.
@saarikabhasi I did the same search, I was asking if you ran these code changes for dedicated as well as serverless? It's extra work but I think it is prudent when making changes to search-api-panels to run Kibana in both modes to verify nothing breaks. |
@TattdCodeMonkey Did a basic manual test by spinning up Kibana in dedicated. Everything looks good. Tests I did:
Went little extra step: Commented out SelectClient component that's being in both Serverless and dedicated. I see page break in getting started page in dedicated. Which I hope expected to happen when something breaks and I don't see same happening in dedicated with this change. Tested same in serverless_search project. Everything looks good. Please let me know if i missed any aspects. |
@elasticmachine merge upstream |
x-pack/plugins/serverless_search/public/application/components/connectors_ingestion.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/serverless_search/public/application/components/connectors_ingestion.tsx
Outdated
Show resolved
Hide resolved
…rikabhasi/kibana into serverless/gs-update-ingest-data-row
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with changes.
The current FTR failures look like flakes from what I can tell. They're not test failures but it looks like the process is exiting with non-zero after the tests complete? |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
PR updates Getting Started Ingest data row to match design .
Screen shot
Screen Recording
Getting.started.ingest.Data.row.mov
Checklist