Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless Search] Update Getting Ingest Data section #171035

Merged

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented Nov 10, 2023

Summary

PR updates Getting Started Ingest data row to match design .

Screen shot

Getting ingest data row

Screen Recording

Getting.started.ingest.Data.row.mov

Checklist

@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0 labels Nov 10, 2023
@saarikabhasi saarikabhasi requested a review from a team November 10, 2023 16:19
@saarikabhasi saarikabhasi changed the title update ingestData row [Serverless Search] Update Getting Ingest Data section Nov 10, 2023
@saarikabhasi saarikabhasi force-pushed the serverless/gs-update-ingest-data-row branch from 6dbe2e1 to b4bc358 Compare November 10, 2023 16:35
@saarikabhasi
Copy link
Member Author

@elasticmachine merge upstream

@saarikabhasi saarikabhasi force-pushed the serverless/gs-update-ingest-data-row branch 2 times, most recently from f17274d to b8e985b Compare November 10, 2023 19:58
@saarikabhasi saarikabhasi force-pushed the serverless/gs-update-ingest-data-row branch from b8e985b to e177582 Compare November 10, 2023 20:28
@TattdCodeMonkey
Copy link
Contributor

@saarikabhasi did you test that these changes don't effect dedicated? I don't think the IntegrationsPanel is used in the enterprise search getting started page that shares the search-api-panels. But it would be good to validate that nothing breaks.

@saarikabhasi
Copy link
Member Author

@TattdCodeMonkey I did a quick search for IntegrationsPanel in elastic/kibana, this component is used only in search-api-panels

https://github.com/search?q=repo%3Aelastic%2Fkibana%20IntegrationsPanel&type=code

@saarikabhasi
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, but we need to address some structural issues with Serverless vs Dedicated.

packages/kbn-search-api-panels/components/ingest_data.tsx Outdated Show resolved Hide resolved
@TattdCodeMonkey
Copy link
Contributor

@saarikabhasi I did the same search, I was asking if you ran these code changes for dedicated as well as serverless?

It's extra work but I think it is prudent when making changes to search-api-panels to run Kibana in both modes to verify nothing breaks.

@saarikabhasi
Copy link
Member Author

saarikabhasi commented Nov 16, 2023

@TattdCodeMonkey Did a basic manual test by spinning up Kibana in dedicated. Everything looks good.

Tests I did:

  • Checked the getting started page, all the links works
  • Able to create a new index - API, crawler, Connector, Create API key, change language clients and tried to ingest content from the example using try in console
  • Created Search applications, behavioural analytics collection, app search engine, visited few pages in stack management.

Went little extra step: Commented out SelectClient component that's being in both Serverless and dedicated. I see page break in getting started page in dedicated. Which I hope expected to happen when something breaks and I don't see same happening in dedicated with this change.

Tested same in serverless_search project. Everything looks good.

Please let me know if i missed any aspects.

@saarikabhasi
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with changes.

@TattdCodeMonkey
Copy link
Contributor

The current FTR failures look like flakes from what I can tell. They're not test failures but it looks like the process is exiting with non-zero after the tests complete?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSearch 300 301 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-api-panels 69 66 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +6.4KB
securitySolutionServerless 330.6KB 336.9KB +6.3KB
serverlessSearch 368.4KB 367.0KB -1.4KB
total +11.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.7KB 41.7KB -1.0B
Unknown metric groups

API count

id before after diff
@kbn/search-api-panels 69 66 -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@saarikabhasi saarikabhasi enabled auto-merge (squash) November 22, 2023 16:32
@saarikabhasi saarikabhasi merged commit a8f2039 into elastic:main Nov 22, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants