Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion Updates Needed due to esarchiver load action concurrency change - x-pack/test/reporting_api_integration/reporting_and_security/download_csv_dashboard.ts #171022

Open
wayneseymour opened this issue Nov 10, 2023 · 3 comments
Labels
Feature:Reporting:CSV Reporting issues pertaining to CSV file export feedback_needed Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) test

Comments

@wayneseymour
Copy link
Member

wayneseymour commented Nov 10, 2023

The es archiver load action is being updated to increase speed.

The usual culprit is the concurrency, which places data out of expected sort order.
We expect placing a sort order in the queries themselves is one solution.
Another could be asserting in such a fashion that does not require a sort order.

This is issue is an attempt to ensure that no decreased coverage, goes overlooked.

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 10, 2023
@jsanz jsanz added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Nov 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan
Copy link
Member

I have a PR to resolve the issue with the file identified in the description of this issue: #171592

Other CSV tests still use snapshots. @wayneseymour let me know if this work needs to update those tests, too.

@tsullivan tsullivan removed their assignment Nov 21, 2023
@wayneseymour wayneseymour changed the title Assertion Updates Needed due to esarchiver load action concurrency change Assertion Updates Needed due to esarchiver load action concurrency change - x-pack/test/reporting_api_integration/reporting_and_security/download_csv_dashboard.ts Dec 11, 2023
@tsullivan
Copy link
Member

@wayneseymour I believe this issue is resolved via #174631

@tsullivan tsullivan added test Feature:Reporting:CSV Reporting issues pertaining to CSV file export labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Reporting:CSV Reporting issues pertaining to CSV file export feedback_needed Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) test
Projects
None yet
Development

No branches or pull requests

4 participants