Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security][Dashboard Enhancements] Metadata Footer Logos/Tooltips #170802

Closed
3 tasks
Omolola-Akinleye opened this issue Nov 7, 2023 · 2 comments · Fixed by #171312
Closed
3 tasks

[Cloud Security][Dashboard Enhancements] Metadata Footer Logos/Tooltips #170802

Omolola-Akinleye opened this issue Nov 7, 2023 · 2 comments · Fixed by #171312
Assignees
@Omolola-Akinleye
Labels
8.12 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related verified

Comments

@Omolola-Akinleye
Copy link
Contributor

Omolola-Akinleye commented Nov 7, 2023 •
edited
Loading

For both views, we should see

  • Each benchmark should show the CIS Logo with CIS Benchmark as a tooltip
  • Each benchmark should show rule version

In Cloud view:

  • Each benchmark, should show the cloud provider logo with rule.benchmark.name as a tooltip

Image

In Kubernetes View:

  • Each benchmark should show orchestrator tool with rule.benchmark.name as the tooltip
  • Keep the same orange Kubernetes outline logo

Image
Image

Figma

Epic - https://github.com/elastic/security-team/issues/7621

Tasks
Preview Give feedback
@Omolola-Akinleye Omolola-Akinleye self-assigned this Nov 7, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 7, 2023
@Omolola-Akinleye Omolola-Akinleye mentioned this issue Nov 7, 2023
Closed
@Omolola-Akinleye Omolola-Akinleye added 8.12 candidate and removed needs-team Issues missing a team label labels Nov 7, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 7, 2023
@Omolola-Akinleye Omolola-Akinleye removed the needs-team Issues missing a team label label Nov 7, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 7, 2023
@Omolola-Akinleye Omolola-Akinleye added the Team:Cloud Security Cloud Security team related label Nov 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 7, 2023
@kfirpeled kfirpeled added the Feature:Cloud-Security Cloud Security related features label Nov 16, 2023
@Omolola-Akinleye Omolola-Akinleye linked a pull request Nov 29, 2023 that will close this issue
Compliance dashboard UI and API #171312
Merged
@animehart
Copy link
Contributor

Cloud view:

  • Benchmark show CIS Logo with CIS Benchmark as tooltip
  • Benchmark Version number are shown in the component
Screenshot 2023-12-12 at 2 37 59 PM

Kubernetes view:

  • Benchmark show CIS Logo with CIS Benchmark as tooltip
  • Benchmark Version number are shown in the component
  • Orange Kubernetes logo for EKS is shown
Screenshot 2023-12-12 at 2 38 43 PM

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Omolola-Akinleye Omolola-Akinleye

Labels
8.12 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compliance dashboard UI and API Omolola-Akinleye/kibana
4 participants
@animehart @elasticmachine @Omolola-Akinleye @kfirpeled