Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Breadcrumb #170642

Closed
cauemarcondes opened this issue Nov 6, 2023 · 2 comments · Fixed by #170792
Closed

[Infra] Breadcrumb #170642

cauemarcondes opened this issue Nov 6, 2023 · 2 comments · Fixed by #170792
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@cauemarcondes
Copy link
Contributor

When navigating the host details page (clicking on a specific host name on the Hosts page) the breadcrumbs is updated removing the hosts page.

The correct path should be: Observability / Infrastructure / Hosts / debian

Screenshot 2023-11-06 at 14 02 15
@cauemarcondes cauemarcondes added bug Fixes for quality problems that affect the customer experience Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@Ruhshan
Copy link
Contributor

Ruhshan commented Nov 7, 2023

Hi @cauemarcondes , could you please take a look at my PR at your convenience. TIA.

jennypavlova added a commit that referenced this issue Dec 20, 2023
…170792)

## Summary

Fixes #170642

Added link to hosts in the breadcrumb for host details page.


![image](https://github.com/elastic/kibana/assets/5312918/273c3b86-bfbd-485c-9bfe-92559caed847)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Cauê Marcondes <[email protected]>
Co-authored-by: jennypavlova <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 20, 2023
…lastic#170792)

## Summary

Fixes elastic#170642

Added link to hosts in the breadcrumb for host details page.

![image](https://github.com/elastic/kibana/assets/5312918/273c3b86-bfbd-485c-9bfe-92559caed847)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Cauê Marcondes <[email protected]>
Co-authored-by: jennypavlova <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit fbd3601)
kibanamachine added a commit that referenced this issue Dec 20, 2023
…rumb (#170792) (#173735)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Observability][Infra] Add parent link in host detail's breadcrumb
(#170792)](#170792)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"ruhshan","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-20T12:38:57Z","message":"[Observability][Infra]
Add parent link in host detail's breadcrumb (#170792)\n\n##
Summary\r\n\r\nFixes #170642\r\n\r\nAdded link to hosts in the
breadcrumb for host details
page.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/5312918/273c3b86-bfbd-485c-9bfe-92559caed847)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<[email protected]>\r\nCo-authored-by:
jennypavlova <[email protected]>\r\nCo-authored-by: Kibana
Machine
<[email protected]>","sha":"fbd3601ced7ab4411d3a2d71a3f9fbe137696f48","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v8.12.0","v8.13.0"],"number":170792,"url":"https://github.com/elastic/kibana/pull/170792","mergeCommit":{"message":"[Observability][Infra]
Add parent link in host detail's breadcrumb (#170792)\n\n##
Summary\r\n\r\nFixes #170642\r\n\r\nAdded link to hosts in the
breadcrumb for host details
page.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/5312918/273c3b86-bfbd-485c-9bfe-92559caed847)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<[email protected]>\r\nCo-authored-by:
jennypavlova <[email protected]>\r\nCo-authored-by: Kibana
Machine
<[email protected]>","sha":"fbd3601ced7ab4411d3a2d71a3f9fbe137696f48"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170792","number":170792,"mergeCommit":{"message":"[Observability][Infra]
Add parent link in host detail's breadcrumb (#170792)\n\n##
Summary\r\n\r\nFixes #170642\r\n\r\nAdded link to hosts in the
breadcrumb for host details
page.\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/5312918/273c3b86-bfbd-485c-9bfe-92559caed847)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Cauê Marcondes
<[email protected]>\r\nCo-authored-by:
jennypavlova <[email protected]>\r\nCo-authored-by: Kibana
Machine
<[email protected]>","sha":"fbd3601ced7ab4411d3a2d71a3f9fbe137696f48"}}]}]
BACKPORT-->

Co-authored-by: ruhshan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants