-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Link to dataset health page from Observability Logs Explorer #170611
Comments
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Got a couple of questions here:
|
I think we should
This is a good question, not sure about this one. For example if a user has selected a dataset inside an integration and we navigate to dataset quality using those values (through filters) they might not understand, quickly, that they can see all of their datasets there. What are your thoughts here @isaclfreire and @ruflin? |
I would separate the dataset health page behaviour to any filtering applied earlier on Logs Explorer. The page itself has already a dedicated search and filtering that has different parameters |
@isaclfreire I see your point. I was just thinking that lets say for example the user is on Logs Explorer with multiple datasets selected and a specific timeframe. The user then clicks on the dataset quality link, would it be best in terms of user experience to move the user's filters along to the quality page ( time filters and dataset selections) or isolate both pages. |
@mohamedhamed-ahmed I see your point, but I still believe both are isolated cases. I challenge the assumption that they would expect any correlation between an interactive component (data selector from search bar +/or query data picker) that shows results in the same page (data grid), and a static link in the sub-header. Both serve different objectives and purposes. If we think users might want/need to check the health of an aggregation of datasets, based or not on a certain timeframe, it's best if we study a dedicated solution that makes the context a bit clearer. |
@isaclfreire Sounds good to me 👍 Thanks for your input :) |
closes #170611 ## 📝 Summary This PR adds the infrastructure work for the locators needed to create the navigation link from the Logs Explorer to the Dataset Quality Page, but the links themselves are to be added with a later ticket. ## 💡For Reviewers To be abled to test this PR you can add the below code [here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx#L150) to make the link visible in the Logs Explorer Page. `<ConnectedDatasetQualityLink /> <VerticalRule />` ## 🎥 Demo https://github.com/elastic/kibana/assets/11225826/1f3ce10a-3b8c-4027-b72d-1ed71b782fa5
closes elastic#170611 ## 📝 Summary This PR adds the infrastructure work for the locators needed to create the navigation link from the Logs Explorer to the Dataset Quality Page, but the links themselves are to be added with a later ticket. ## 💡For Reviewers To be abled to test this PR you can add the below code [here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx#L150) to make the link visible in the Logs Explorer Page. `<ConnectedDatasetQualityLink /> <VerticalRule />` ## 🎥 Demo https://github.com/elastic/kibana/assets/11225826/1f3ce10a-3b8c-4027-b72d-1ed71b782fa5
📓 Summary
Allow users to navigate to the page.
✔️ Acceptance criteria
Observability
>Logs
>Explorer
>Datasets
Log Explorer
>Datasets
💡 Implementation hints
x-pack/plugins/observability_log_explorer/public/components/log_explorer_top_nav_menu.tsx
.The text was updated successfully, but these errors were encountered: