Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Link to dataset health page from Observability Logs Explorer #170611

Closed
yngrdyn opened this issue Nov 6, 2023 · 7 comments · Fixed by #177000
Closed

[Dataset quality] Link to dataset health page from Observability Logs Explorer #170611

yngrdyn opened this issue Nov 6, 2023 · 7 comments · Fixed by #177000
Assignees
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Nov 6, 2023

📓 Summary

Allow users to navigate to the page.

image

✔️ Acceptance criteria

  • A link is added to Observability Log Explorer
    • User is redirected to dataset health page when clicking the link
  • Breadcrumbs reflect the path the user took to get to the page
    • stateful: Observability > Logs > Explorer > Datasets
    • serverless: Log Explorer > Datasets

💡 Implementation hints

  • The link should be placed in x-pack/plugins/observability_log_explorer/public/components/log_explorer_top_nav_menu.tsx.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 6, 2023
@yngrdyn yngrdyn added Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels Nov 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 6, 2023
@yngrdyn yngrdyn changed the title [Dataset health] Link to dataset health page from Observability Logs Explorer [Dataset quality] Link to dataset health page from Observability Logs Explorer Nov 9, 2023
@mohamedhamed-ahmed
Copy link
Contributor

Got a couple of questions here:

  1. Are we planning to implement this using locators (probably)
  2. Do we need to carry over any filtrations or params from the log explorer?

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Feb 8, 2024

  1. Are we planning to implement this using locators (probably)

I think we should

  1. Do we need to carry over any filtrations or params from the log explorer?

This is a good question, not sure about this one. For example if a user has selected a dataset inside an integration and we navigate to dataset quality using those values (through filters) they might not understand, quickly, that they can see all of their datasets there. What are your thoughts here @isaclfreire and @ruflin?

@isaclfreire
Copy link

I would separate the dataset health page behaviour to any filtering applied earlier on Logs Explorer. The page itself has already a dedicated search and filtering that has different parameters

@mohamedhamed-ahmed
Copy link
Contributor

mohamedhamed-ahmed commented Feb 8, 2024

@isaclfreire I see your point. I was just thinking that lets say for example the user is on Logs Explorer with multiple datasets selected and a specific timeframe. The user then clicks on the dataset quality link, would it be best in terms of user experience to move the user's filters along to the quality page ( time filters and dataset selections) or isolate both pages.

@isaclfreire
Copy link

@mohamedhamed-ahmed I see your point, but I still believe both are isolated cases. I challenge the assumption that they would expect any correlation between an interactive component (data selector from search bar +/or query data picker) that shows results in the same page (data grid), and a static link in the sub-header. Both serve different objectives and purposes.

If we think users might want/need to check the health of an aggregation of datasets, based or not on a certain timeframe, it's best if we study a dedicated solution that makes the context a bit clearer.

@mohamedhamed-ahmed
Copy link
Contributor

@isaclfreire Sounds good to me 👍 Thanks for your input :)

@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Feb 12, 2024
yngrdyn pushed a commit that referenced this issue Feb 22, 2024
closes #170611

## 📝  Summary

This PR adds the infrastructure work for the locators needed to create
the navigation link from the Logs Explorer to the Dataset Quality Page,
but the links themselves are to be added with a later ticket.

## 💡For Reviewers

To be abled to test this PR you can add the below code
[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx#L150)
to make the link visible in the Logs Explorer Page.

`<ConnectedDatasetQualityLink />
  <VerticalRule />`

## 🎥 Demo



https://github.com/elastic/kibana/assets/11225826/1f3ce10a-3b8c-4027-b72d-1ed71b782fa5
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
closes elastic#170611

## 📝  Summary

This PR adds the infrastructure work for the locators needed to create
the navigation link from the Logs Explorer to the Dataset Quality Page,
but the links themselves are to be added with a later ticket.

## 💡For Reviewers

To be abled to test this PR you can add the below code
[here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx#L150)
to make the link visible in the Logs Explorer Page.

`<ConnectedDatasetQualityLink />
  <VerticalRule />`

## 🎥 Demo



https://github.com/elastic/kibana/assets/11225826/1f3ce10a-3b8c-4027-b72d-1ed71b782fa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants