[Saved Queries] Improve saved query management #170599

davismcphee · 2023-11-06T03:20:02Z

Summary

This PR introduces a number of changes and improvements to saved query management:

Add server side pagination (5 queries per page) and search functionality to the "Load query" list, which improves UX and performance by no longer requesting all queries at once.
Redesign the "Load query" list to improve the UX and a11y, making it possible for keyboard users to effectively navigate the list and load/delete queries.
Add an "Active" badge to the "Load query" list to indicate which list entry represents the currently loaded query, and hoist the entry to the top of the first page for better visibility when no search term exists.
Deprecate the saved query /_all endpoint and update it to return only the first 100 queries instead of loading them all into memory at once.
Add a new titleKeyword field to the saved query SO, which allows sorting queries alphabetically by title when displaying them in the "Load query" list.
Improve the performance of the "has saved queries" check when Unified Search is mounted to no longer request actual queries, and instead just request the count.
Update the saved query duplicate title check to no longer rely on fetching all queries at once, and instead asynchronously check for duplicates by title on save.
Add server side duplicate title validation to the create and update saved query endpoints.
Various small fixes and cleanups throughout saved query management.

saved_query_management.mp4

Resolves #172044.
Resolves #176427.

Testing

To generate saved queries for testing, run the script below and replace {KIBANA_REQUEST_COOKIE} with the cookie header value from an API request of a Kibana user with an active session:

for i in {1..100}; do curl 'http://localhost:5601/internal/saved_query/_create' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-US,en;q=0.9,az;q=0.8,es;q=0.7' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: application/json' \
  -H 'Cookie: {KIBANA_REQUEST_COOKIE}' \
  -H 'elastic-api-version: 1' \
  -H 'kbn-build-number: 9007199254740991' \
  -H 'kbn-version: 8.13.0' \
  -H 'x-elastic-internal-origin: Kibana' \
  --data-raw '{"title":"query '"$(echo $(($i - 1)) | tr '[0-9]' '[a-j]')"'","description":"","query":{"query":"bytes > 500","language":"kuery"},"filters":[]}' \
  --compressed; done

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

andreadelrio · 2023-12-05T02:16:38Z

@davismcphee Thanks for working on improving this UI! Here are some design comments:

The current footer / bottom section feels quite busy to me. I've put together two alternatives that use patterns we use elsewhere in Kibana (controls and the upcoming CCS popover) to try to achieve a cleaner look. See below.
Something about the blur you have at the bottom of the list made me think this had infinite scrolling when I first watched your demo. I would prefer to show a smaller number of queries per page. I think 5 would work nicely but we can discuss a higher number too.
To try and reduce how crowded the bottom section is, I suggest we only use a gear icon for the Manage saved objects link. If we have concerns about the discoverability of this option we could add an item for this to the "Saved queries" menu. I also recommend we rename the label to Manage saved queries.

Here are the two alternatives I'm proposing:

I think I lean towards option 1 because we usually do something like option 2 when users can select multiple items in a list and can apply bulk actions.

ninoslavmiskovic · 2023-12-05T12:42:02Z

@andreadelrio I like the option 1 👍

davismcphee · 2023-12-06T21:15:00Z

@andreadelrio Thanks for the design review! I also prefer option 1, and am working on implementing the suggested changes 👍

davismcphee · 2023-12-07T23:11:43Z

/ci

davismcphee · 2023-12-08T02:42:17Z

/ci

davismcphee · 2023-12-08T05:26:53Z

/ci

davismcphee · 2023-12-08T18:10:45Z

/ci

andreadelrio · 2023-12-08T22:46:08Z

src/plugins/unified_search/public/saved_query_management/saved_query_management_list.scss

-.kbnSavedQueryManagement__text {
-  padding: $euiSizeM $euiSizeM ($euiSizeM / 2) $euiSizeM;
+  .euiSelectableListItem {
+    border-bottom: 1px solid darken($euiColorLightestShade, 2%);


I'm not sure we need this line. If it's not supported natively from EUI I hesitate to add it. It creates a double border in the footer when there's only one page. I see we either remove it altogether or include it only when there's more than one page. What do you think @davismcphee ?

Probably the fewer overrides the better, so I'm in favour of removing it altogether. Dropped it in this commit: 17c60c3.

One other thing I overrode to try to better match the designs is removing the blue background on the focused list entry. In general I think this looks better, but now the only indicator of the focused field for keyboard users is the text underline. Do you think this is fine, or should I bring back the blue background/add another indicator of some sort?

@davismcphee I say you bring back the blue background as the few overrides the better lifestyle recommends 😉.

Done! acf4cf0

davismcphee · 2024-01-16T01:13:05Z

/ci

davismcphee · 2024-01-16T02:50:48Z

src/plugins/data/server/query/route_handler_context.ts

+      page: 0,
+      perPage: 0,


ℹ️ Minor performance optimization to no longer request documents when we only need the total.

davismcphee · 2024-01-16T02:51:30Z

src/plugins/data/server/query/route_handler_context.ts

+        sortField: search ? undefined : 'titleKeyword',
+        sortOrder: search ? undefined : 'asc',


ℹ️ If no search term is passed, we sort by title alphabetically. If a search term is passed, we use the default score based sorting.

davismcphee · 2024-01-16T02:57:38Z

src/plugins/data/server/query/routes.ts

@@ -178,6 +178,7 @@ export function registerSavedQueryRoutes({ http }: CoreSetup): void {
    }
  );

+  // TODO: We no longer support fetching all saved queries, so this route should be removed


I updated the /_all endpoint to only load the first 100 saved queries which addresses the concern of loading too many into memory at once, but should we just fully remove the endpoint instead? It's an undocumented internal endpoint that has no remaining consumers in Kibana, but I'm not sure how we usually approach endpoint removals.

I'd be all for removing the endpoint altogether. Like you mentioned it's not documented as a public API.

I ended up dropping the endpoint entirely here: e48acf9. Although now I'm wondering if this change is safe for ZDT upgrades. @elastic/kibana-core is it safe for us to remove this internal endpoint in the same release we stop using it, or could it be an issue for upgrades?

Removing an endpoint that isn't used internally should be ok if you're sure we don't have external services consuming the endpoint (fleet, agent, etc).

3rd party integrations and external consumers might be an issue but, as you mentioned, the endpoint is internal and isn't documented.

You could rather deprecate the endpoint with a short deprecation timeframe and see if there are any concerns/problems.

The main concern with ZDT upgrades is a scenario where the UI uses an API, then when we roll an update to remove the API a user could encounter breakage if they still have cached the old UI.

Core recommends the safest way forward for removing an internal endpoint is to (1) remove all usage, (2) wait for 2 (serverless) releases to allow for rollbacks, and then (3) remove the API. The approximate timeframe is 3-4 weeks, depending on when this commit lands.

davismcphee · 2024-01-16T03:03:44Z

src/plugins/unified_search/public/query_string_input/add_filter_popover.tsx

@@ -91,11 +88,11 @@ const AddFilterPopoverComponent = React.memo(function AddFilterPopover({
        panelPaddingSize="none"
        panelProps={{
          'data-test-subj': 'addFilterPopover',
-          css: popoverDragAndDropCss(euiTheme),


ℹ️ EUI now supports this by default through the hasDragDrop prop.

davismcphee · 2024-01-16T03:06:04Z

src/plugins/unified_search/public/query_string_input/query_bar_menu_panels.tsx

@@ -437,8 +445,7 @@ export function QueryBarMenuPanels({
    {
      id: 1,
      title: strings.getSaveCurrentFilterSetLabel(),
-      disabled: !Boolean(showSaveQuery),


ℹ️ Removed because disabled doesn't exist on EuiContextMenuPanelItemDescriptor.

davismcphee · 2024-01-16T03:06:48Z

src/plugins/unified_search/public/query_string_input/query_bar_menu_panels.tsx

@@ -509,11 +516,10 @@ export function QueryBarMenuPanels({
    },
    {
      id: 4,
-      title: strings.getLoadCurrentFilterSetLabel(),


ℹ️ Removed because title doesn't exist on EuiContextMenuPanelItemDescriptor.

davismcphee · 2024-01-16T05:23:32Z

/ci

davismcphee · 2024-01-17T01:11:30Z

/ci

davismcphee · 2024-01-17T01:52:50Z

x-pack/plugins/lens/public/app_plugin/lens_top_nav.tsx

+      // If the user tries to load the same saved query that is already loaded,
+      // we will receive the same object reference which was previously frozen
+      // by Redux Toolkit. `filterManager.setFilters` will then try to modify
+      // the query's filters, which will throw an error. To avoid this, we need
+      // to clone the filters before passing them to `filterManager.setFilters`.
+      const savedQueryFilters = cloneDeep(newSavedQuery.attributes.filters || []);


ℹ️ This bug was already present in main, but was never caught in any functional tests until I added this check to test/functional/services/saved_query_management_component.ts, which caused it to start triggering test failures: https://github.com/elastic/kibana/blob/119ca6d36d044f3ec0997a409fc119532ecc448e/test/functional/services/saved_query_management_component.ts#L90-L92

great catch!

davismcphee · 2024-01-17T06:00:56Z

/ci

davismcphee · 2024-01-17T18:06:11Z

/ci

davismcphee · 2024-01-17T22:34:03Z

src/plugins/unified_search/public/search_bar/search_bar.tsx

-  private hasFiltersOrQuery() {
-    const hasFilters = Boolean(this.props.filters && this.props.filters.length > 0);
-    const hasQuery = Boolean(
-      this.state.query && isOfQueryType(this.state.query) && this.state.query.query
-    );
-    return hasFilters || hasQuery;
-  }


ℹ️ Dropped this because it was only being passed to SavedQueryManagementList which wasn't using it anyway.

…ll queries

jughosta

Awesome! Thanks for all the work you've done to improve Saved queries UI and fix bugs in it!

The only remaining concern from my side is that React shows lots of warnings when opening "Load query" panel.

jughosta · 2024-02-07T09:38:41Z

src/plugins/unified_search/public/saved_query_management/saved_query_management_list.tsx

+const SAVED_QUERY_PAGE_SIZE = 5;
+const SAVED_QUERY_SEARCH_DEBOUNCE = 500;
+
+export const SavedQueryManagementList = ({


I get them every time I open "Load queries" panel. Can you try in Chrome?

jughosta · 2024-02-07T09:40:00Z

src/plugins/unified_search/public/saved_query_management/saved_query_management_list.tsx

-        cancelPendingListingRequest.current();
-        setSavedQueries(
-          savedQueries.filter((currentSavedQuery) => currentSavedQuery.id !== savedQueryId)
+        setTotalQueryCount((currentTotalQueryCount) => max([0, currentTotalQueryCount - 1])!);


Suggested change

setTotalQueryCount((currentTotalQueryCount) => max([0, currentTotalQueryCount - 1])!);

setTotalQueryCount((currentTotalQueryCount) => Math.max(0, currentTotalQueryCount - 1)!);

Too much coding is making me forgetful 🙂 The standard lib is always preferable, changed it here: 032a918.

jughosta · 2024-02-07T09:41:53Z

test/api_integration/apis/saved_queries/saved_queries.ts

+          ));
+    });
+  });
+}


Great! Thanks for improving tests too!

lukasolson

LGTM - Thanks for seeing this through! So much goodness inside.

I did find another case where searching for the exact title doesn't work - something like "what's up". It turns out the standard analyzer breaks this up into two tokens ["what's", "up"] and not three (["what", "s", "up"]). We could fix this by changing the regex a little bit, but I don't want to delay this PR and all its improvements with making everything work exactly as the default analyzers.

…, which is called within useMemo, and leads to nested hook calls

…fix'

davismcphee

I did find another case where searching for the exact title doesn't work - something like "what's up".

Welp, good catch 😢 I think this could be worth addressing (maybe someone's possessive about their queries 😁), but maybe we can work together on a more robust regex as followup since we can safely backport it after FF as a bug fix... Then beg for DSL support as followup-followup.

davismcphee · 2024-02-08T00:20:18Z

src/plugins/unified_search/public/saved_query_management/saved_query_management_list.tsx

+const SAVED_QUERY_PAGE_SIZE = 5;
+const SAVED_QUERY_SEARCH_DEBOUNCE = 500;
+
+export const SavedQueryManagementList = ({


This one was trickier to address than anticipated due to the EUI pretty duration utils. It required a workaround to address, but I think it's better than all the errors and is at least consistent with what we do elsewhere in Kibana: 94e9361.

davismcphee · 2024-02-08T00:21:31Z

src/plugins/unified_search/public/saved_query_management/saved_query_management_list.tsx

-        cancelPendingListingRequest.current();
-        setSavedQueries(
-          savedQueries.filter((currentSavedQuery) => currentSavedQuery.id !== savedQueryId)
+        setTotalQueryCount((currentTotalQueryCount) => max([0, currentTotalQueryCount - 1])!);


Too much coding is making me forgetful 🙂 The standard lib is always preferable, changed it here: 032a918.

stratoula · 2024-02-08T07:51:09Z

/ci

stratoula

This works great, thanx Davis. Very nice enhancement. I just have one comment, this 1 selected seems a bit weird. Can we remove it before merging? I saw that Andrea is also ok with it. I am approving as I assume you are going to address it!

jughosta

LGTM 👍 Thanks, Davis!

banderror

The change in x-pack/plugins/security_solution/public/common/lib/kibana/kibana_react.mock.ts LGTM 👍

michaelolo24

Thanks for making these changes! Investigations changes 🚀 💯

kibana-ci · 2024-02-12T06:48:52Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 41605ec

Failed CI Steps

Defend Workflows Cypress Tests on Serverless #2

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`unifiedSearch`	222	233	+11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	2585	2587	+2
`unifiedSearch`	110	113	+3
total			+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.4MB	1.4MB	+22.0B
`unifiedSearch`	217.2KB	223.8KB	+6.7KB
total			+6.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	415.6KB	415.6KB	+33.0B
`unifiedSearch`	35.7KB	35.8KB	+58.0B
total			+91.0B

Unknown metric groups

API count

id	before	after	diff
`data`	3237	3239	+2
`unifiedSearch`	148	151	+3
total			+5

History

💚 Build #192654 succeeded 62281ff
💔 Build #192582 failed 9888240
💔 Build #192451 failed 6dd865a
💔 Build #192449 failed d98d2c2
💛 Build #192148 was flaky 9a09649
💛 Build #192118 was flaky 8736091

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @andreadelrio @davismcphee

davismcphee · 2024-02-12T17:19:11Z

Just an FYI that I've created a followup issue here to address some of the concerns that didn't make it into this PR: #176730. Please update or comment on the followup issue if there are any concerns I missed.

## Summary This PR introduces a number of changes and improvements to saved query management: - Add server side pagination (5 queries per page) and search functionality to the "Load query" list, which improves UX and performance by no longer requesting all queries at once. - Redesign the "Load query" list to improve the UX and a11y, making it possible for keyboard users to effectively navigate the list and load/delete queries. - Add an "Active" badge to the "Load query" list to indicate which list entry represents the currently loaded query, and hoist the entry to the top of the first page for better visibility when no search term exists. - Deprecate the saved query `/_all` endpoint and update it to return only the first 100 queries instead of loading them all into memory at once. - Add a new `titleKeyword` field to the saved query SO, which allows sorting queries alphabetically by title when displaying them in the "Load query" list. - Improve the performance of the "has saved queries" check when Unified Search is mounted to no longer request actual queries, and instead just request the count. - Update the saved query duplicate title check to no longer rely on fetching all queries at once, and instead asynchronously check for duplicates by title on save. - Add server side duplicate title validation to the create and update saved query endpoints. - Various small fixes and cleanups throughout saved query management. https://github.com/elastic/kibana/assets/25592674/43328aea-0f7b-4b7a-a5fb-e33ed822f317 Resolves elastic#172044. Resolves elastic#176427. ## Testing To generate saved queries for testing, run the script below and replace `{KIBANA_REQUEST_COOKIE}` with the cookie header value from an API request of a Kibana user with an active session: ```shell for i in {1..100}; do curl 'http://localhost:5601/internal/saved_query/_create' \ -H 'Accept: */*' \ -H 'Accept-Language: en-US,en;q=0.9,az;q=0.8,es;q=0.7' \ -H 'Cache-Control: no-cache' \ -H 'Connection: keep-alive' \ -H 'Content-Type: application/json' \ -H 'Cookie: {KIBANA_REQUEST_COOKIE}' \ -H 'elastic-api-version: 1' \ -H 'kbn-build-number: 9007199254740991' \ -H 'kbn-version: 8.13.0' \ -H 'x-elastic-internal-origin: Kibana' \ --data-raw '{"title":"query '"$(echo $(($i - 1)) | tr '[0-9]' '[a-j]')"'","description":"","query":{"query":"bytes > 500","language":"kuery"},"filters":[]}' \ --compressed; done ``` ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>

davismcphee added release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Unified search Unified search related tasks labels Nov 6, 2023

davismcphee self-assigned this Nov 6, 2023

lukasolson mentioned this pull request Nov 7, 2023

Add saved query title/description validation #167454

Closed

1 task

andreadelrio self-assigned this Dec 5, 2023

davismcphee force-pushed the saved-query-impovements branch from b967bee to 6bcb417 Compare December 6, 2023 21:10

davismcphee force-pushed the saved-query-impovements branch from 633b213 to 74410a2 Compare December 8, 2023 01:03

andreadelrio reviewed Dec 8, 2023

View reviewed changes

davismcphee force-pushed the saved-query-impovements branch from cf6b635 to d6ee700 Compare January 16, 2024 01:09

davismcphee commented Jan 16, 2024

View reviewed changes

davismcphee force-pushed the saved-query-impovements branch 2 times, most recently from 5ba975a to 119ca6d Compare January 17, 2024 01:10

davismcphee commented Jan 17, 2024

View reviewed changes

davismcphee added 3 commits January 17, 2024 18:54

Optimize saved queries exist check

744a72e

Check for saved query title conflicts at save instead of preloading a…

ef1a293

…ll queries

Add pagination to saved query list

88026dd

jughosta reviewed Feb 7, 2024

View reviewed changes

davismcphee mentioned this pull request Feb 7, 2024

[Saved Queries] "Save query" button is grayed out/disabled even after changing filters #176427

Closed

lukasolson approved these changes Feb 7, 2024

View reviewed changes

davismcphee and others added 3 commits February 7, 2024 20:06

Fix React errors caused by calling usePrettyDuration within itemTitle…

94e9361

…, which is called within useMemo, and leads to nested hook calls

Switch from lodash max to Math.max

032a918

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

8736091

…fix'

davismcphee commented Feb 8, 2024

View reviewed changes

Merge branch 'main' into saved-query-impovements

9a09649

stratoula approved these changes Feb 8, 2024

View reviewed changes

jughosta approved these changes Feb 8, 2024

View reviewed changes

banderror approved these changes Feb 8, 2024

View reviewed changes

michaelolo24 approved these changes Feb 8, 2024

View reviewed changes

davismcphee added 6 commits February 9, 2024 01:01

Merge branch 'main' into saved-query-impovements

d98d2c2

Fix current_mappings.json

6dd865a

Merge branch 'main' into saved-query-impovements

9888240

Merge branch 'main' into saved-query-impovements

5eff403

Merge branch 'main' into saved-query-impovements

62281ff

Merge branch 'main' into saved-query-impovements

41605ec

davismcphee mentioned this pull request Feb 12, 2024

[Saved Queries] Improve saved query management followups #176730

Open

davismcphee added the v8.13.0 label Feb 12, 2024

davismcphee merged commit 509248b into elastic:main Feb 12, 2024
39 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Feb 12, 2024

davismcphee deleted the saved-query-impovements branch February 12, 2024 20:23

lukasolson mentioned this pull request Apr 24, 2024

[Security Solution] Unable to search saved query if query added include time filter OR cursor issue in search field if added without include time filter. #132221

Closed

		sortField: search ? undefined : 'titleKeyword',
		sortOrder: search ? undefined : 'asc',

	setTotalQueryCount((currentTotalQueryCount) => max([0, currentTotalQueryCount - 1])!);
	setTotalQueryCount((currentTotalQueryCount) => Math.max(0, currentTotalQueryCount - 1)!);

[Saved Queries] Improve saved query management #170599

[Saved Queries] Improve saved query management #170599

Conversation

davismcphee commented Nov 6, 2023 • edited Loading

Summary

Testing

Checklist

For maintainers

andreadelrio commented Dec 5, 2023

ninoslavmiskovic commented Dec 5, 2023

davismcphee commented Dec 6, 2023

davismcphee commented Dec 7, 2023

davismcphee commented Dec 8, 2023

davismcphee commented Dec 8, 2023

davismcphee commented Dec 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davismcphee commented Jan 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davismcphee commented Jan 16, 2024

davismcphee commented Jan 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davismcphee commented Jan 17, 2024

davismcphee commented Jan 17, 2024

Choose a reason for hiding this comment

jughosta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukasolson left a comment

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stratoula commented Feb 8, 2024

stratoula left a comment

Choose a reason for hiding this comment

jughosta left a comment

Choose a reason for hiding this comment

banderror left a comment

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

kibana-ci commented Feb 12, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

davismcphee commented Feb 12, 2024 • edited Loading

davismcphee commented Nov 6, 2023 •

edited

Loading

TinaHeiligers Jan 30, 2024 •

edited

Loading

TinaHeiligers Jan 30, 2024 •

edited

Loading

davismcphee commented Feb 12, 2024 •

edited

Loading