Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] [RAM] Reset rule settings modal on cancel (#169720) #169869

Merged
merged 3 commits into from
Oct 26, 2023
Merged

[8.11] [RAM] Reset rule settings modal on cancel (#169720) #169869

merged 3 commits into from
Oct 26, 2023

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 25, 2023

Backport

This will backport the following commits from main to 8.11:

Questions ?

Please refer to the Backport tool documentation

@Zacqary
[RAM] Reset rule settings modal on cancel (elastic#169720)
75b7e06 
## Summary

Fixes elastic#169296

- Resets the rule settings modal when the user clicks Cancel, but caches
the initial pull from the server so that a second request isn't
necessary on reopen
- Updates this cache on save so that the reset on modal close remains
accurate

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 3a5d6cc)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/components/rules_setting/rules_settings_modal.tsx
@Zacqary Zacqary enabled auto-merge (squash) October 25, 2023 18:43
@Zacqary Zacqary mentioned this pull request Oct 25, 2023
Merged
1 task
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #45 / InfraOps App Metrics UI Home page with metrics present Asset Details flyout APM Link Tab should navigate to APM traces
  • [job] [logs] FTR Configs #24 / pluggable panel actions "after all" hook in "pluggable panel actions"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +651.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary requested a review from a team October 26, 2023 02:07
@Zacqary Zacqary merged commit 650a8ac into elastic:8.11 Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zacqary @apmmachine @kibana-ci @XavierM @kibanamachine