Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack API Integration Tests.x-pack/test/api_integration/apis/synthetics/get_monitor·ts - Synthetics API Tests getSyntheticsMonitors get many monitors with page params #169753

Closed
Tracked by #190068
kibanamachine opened this issue Oct 25, 2023 · 14 comments · Fixed by #190404 or #196109
Closed
Tracked by #190068

Failing test: X-Pack API Integration Tests.x-pack/test/api_integration/apis/synthetics/get_monitor·ts - Synthetics API Tests getSyntheticsMonitors get many monitors with page params #169753

kibanamachine opened this issue Oct 25, 2023 · 14 comments · Fixed by #190404 or #196109
Assignees
@shahzad31
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-management Observability Management User Experience Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 25, 2023 •
edited
Loading

A test failed on a tracked branch

Error: expected '7114ade8-23a4-4e03-9515-8db69f80418f' to sort of not equal '7114ade8-23a4-4e03-9515-8db69f80418f'
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at Context.<anonymous> (get_monitor.ts:103:55)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:73:16) {
  actual: '7114ade8-23a4-4e03-9515-8db69f80418f',
  expected: '7114ade8-23a4-4e03-9515-8db69f80418f',
  showDiff: true
}

First failure: CI Build - 8.11
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 25, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 25, 2023
@kibanamachine kibanamachine added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 25, 2023
@kibanamachine kibanamachine reopened this Nov 15, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@paulb-elastic
Copy link
Contributor

@justinkambic @smith I have put this onto your board to take a look

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@paulb-elastic paulb-elastic added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Mar 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@paulb-elastic paulb-elastic removed the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 8, 2024
mistic added a commit that referenced this issue Mar 8, 2024
@mistic
skip flaky suite (#169753)
fa4d2d0
@mistic
Copy link
Member

mistic commented Mar 8, 2024

Skipped.

main: fa4d2d0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.13

@smith smith added Team:obs-ux-management Observability Management User Experience Team and removed Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@bhavyarm bhavyarm added v8.15.0 and removed v8.14.0 labels Jul 31, 2024
@jasonrhodes jasonrhodes mentioned this issue Aug 7, 2024
Open
@shahzad31 shahzad31 self-assigned this Aug 13, 2024
@shahzad31 shahzad31 mentioned this issue Aug 13, 2024
Merged
shahzad31 added a commit that referenced this issue Aug 13, 2024
@shahzad31
[Synthetics] Unskip get too many monitors test !! (#190404)
386d290 
## Summary

Fixes #169753 !!

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6753
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 13, 2024
@shahzad31 @bryce-b
[Synthetics] Unskip get too many monitors test !! (elastic#190404)
d259d4f 
## Summary

Fixes elastic#169753 !!

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6753
@kibanamachine kibanamachine reopened this Aug 13, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Aug 14, 2024
@mistic
skip flaky suite (#169753)
b336eec
@mistic
Copy link
Member

mistic commented Aug 14, 2024

Skipped.

main: b336eec

@shahzad31 shahzad31 mentioned this issue Oct 15, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 16, 2024
@shahzad31
[Synthetic] Show monitors from all permitted spaces !! (elastic#196109)
0965384 
## Summary

Fixes elastic#194760 !!
Fixes elastic#169753 !!

Added an options to list monitors from all spaces which user has
permission for , user can either select default option which is to get
monitors from current space or all permitted spaces !!

### Testing

Create monitors in 3 spaces, assign 2 spaces to a role, and create a
user. Make sure monitors only appears to which user have space
permission.

<img width="1727" alt="image"
src="https://github.com/user-attachments/assets/972d213a-ee00-4950-be9f-a209393cb69a">

---------

Co-authored-by: Justin Kambic <[email protected]>
(cherry picked from commit 2f67874)
kibanamachine added a commit that referenced this issue Oct 16, 2024
@kibanamachine @shahzad31
[8.x] [Synthetic] Show monitors from all permitted spaces !! (#196109) (
2c833fd 
#196596)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetic] Show monitors from all permitted spaces !!
(#196109)](#196109)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T19:08:34Z","message":"[Synthetic]
Show monitors from all permitted spaces !! (#196109)\n\n##
Summary\n\nFixes #194760
!!\nFixes #169753 !!\n\nAdded an
options to list monitors from all spaces which user has\npermission for
, user can either select default option which is to get\nmonitors from
current space or all permitted spaces !!\n\n### Testing\n\nCreate
monitors in 3 spaces, assign 2 spaces to a role, and create a\nuser.
Make sure monitors only appears to which user have
space\npermission.\n\n<img width=\"1727\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/972d213a-ee00-4950-be9f-a209393cb69a\">\n\n---------\n\nCo-authored-by:
Justin Kambic
<[email protected]>","sha":"2f678744ab3b512cf5e212671a35b81edd1aeec9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","release_note:feature","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"[Synthetic]
Show monitors from all permitted spaces
!!","number":196109,"url":"https://github.com/elastic/kibana/pull/196109","mergeCommit":{"message":"[Synthetic]
Show monitors from all permitted spaces !! (#196109)\n\n##
Summary\n\nFixes #194760
!!\nFixes #169753 !!\n\nAdded an
options to list monitors from all spaces which user has\npermission for
, user can either select default option which is to get\nmonitors from
current space or all permitted spaces !!\n\n### Testing\n\nCreate
monitors in 3 spaces, assign 2 spaces to a role, and create a\nuser.
Make sure monitors only appears to which user have
space\npermission.\n\n<img width=\"1727\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/972d213a-ee00-4950-be9f-a209393cb69a\">\n\n---------\n\nCo-authored-by:
Justin Kambic
<[email protected]>","sha":"2f678744ab3b512cf5e212671a35b81edd1aeec9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196109","number":196109,"mergeCommit":{"message":"[Synthetic]
Show monitors from all permitted spaces !! (#196109)\n\n##
Summary\n\nFixes #194760
!!\nFixes #169753 !!\n\nAdded an
options to list monitors from all spaces which user has\npermission for
, user can either select default option which is to get\nmonitors from
current space or all permitted spaces !!\n\n### Testing\n\nCreate
monitors in 3 spaces, assign 2 spaces to a role, and create a\nuser.
Make sure monitors only appears to which user have
space\npermission.\n\n<img width=\"1727\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/972d213a-ee00-4950-be9f-a209393cb69a\">\n\n---------\n\nCo-authored-by:
Justin Kambic
<[email protected]>","sha":"2f678744ab3b512cf5e212671a35b81edd1aeec9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this issue Oct 17, 2024
@shahzad31 @justinkambic @hop-dev
[Synthetic] Show monitors from all permitted spaces !! (elastic#196109)
5563721 
## Summary

Fixes elastic#194760 !!
Fixes elastic#169753 !!

Added an options to list monitors from all spaces which user has
permission for , user can either select default option which is to get
monitors from current space or all permitted spaces !!

### Testing

Create monitors in 3 spaces, assign 2 spaces to a role, and create a
user. Make sure monitors only appears to which user have space
permission.

<img width="1727" alt="image"
src="https://github.com/user-attachments/assets/972d213a-ee00-4950-be9f-a209393cb69a">

---------

Co-authored-by: Justin Kambic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
8 participants
@smith @crespocarlos @shahzad31 @mistic @bhavyarm @elasticmachine @kibanamachine @paulb-elastic