Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix threshold and value format in custom threshold rule similar to what we have for metric threshold in the rule flyout #169364

Closed
maryam-saeidi opened this issue Oct 19, 2023 · 2 comments · Fixed by #170306
Closed

Fix threshold and value format in custom threshold rule similar to what we have for metric threshold in the rule flyout #169364

maryam-saeidi opened this issue Oct 19, 2023 · 2 comments · Fixed by #170306
Assignees
@maryam-saeidi
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@maryam-saeidi
Copy link
Member

📝 Summary

We don't have proper formatting for the custom threshold rule. We need to fix that according to what we have in the metric threshold.

Custom threshold Metric threshold
image image

✅ Acceptance Criteria

  • Fix threshold and value format in custom threshold rule similar to what we have for metric threshold in the rule flyout
@maryam-saeidi maryam-saeidi added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Oct 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi self-assigned this Oct 25, 2023
@maryam-saeidi maryam-saeidi mentioned this issue Nov 1, 2023
Merged
@paulb-elastic paulb-elastic added the Team:obs-ux-management Observability Management User Experience Team label Nov 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@paulb-elastic paulb-elastic removed the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Nov 10, 2023
maryam-saeidi added a commit that referenced this issue Nov 14, 2023
@maryam-saeidi @kibanamachine @fkanout
Revisit custom threshold types in public folder (#170306)
6f2ad26 
Part of #159340
Closes #169364

## Summary

This PR:
1. Removes preFill logic
In this PR, I removed the logic about prefilling custom threshold rule
params as it was originally for other rule types (not custom equation)
and to be used in the Metric threshold rule and the code related to this
logic was super confusing, and I wasn't even sure if it works as
expected since we haven't used this logic anywhere. I created a
[ticket](#170295) to bring back
this feature properly later, specifically for the custom equation, and
integrate it in one of the apps, such as Infra. We also need to be able
to preFill data view information (both adHoc and persisted data view)
2. Renames types and file names 
      - From `metricThreshold` to `customThreshold`
      - From `metricExplorer` to `expression`
3. Removes unused types
4. Remove logic related to aggregations other than the custom equation
at the top level

Also, the fields that end with `pct` now have the `%` after the related
value: (The reason message was fixed in another PR)

<img
src="https://github.com/elastic/kibana/assets/12370520/83694d3b-2ee2-4e95-afe9-5a959c76c3c7"
width=400 />


## 🧪 How to test
- Nothing has changed related to functionality, so please make sure the
custom threshold rule is working as before for
    - Creating a new rule with multiple conditions
    - Adding groups
    - Editing a rule and checking the charts are shown as before
    - Test both adHoc and persisted data view

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Faisal Kanout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revisit custom threshold types in public folder maryam-saeidi/kibana
3 participants
@maryam-saeidi @elasticmachine @paulb-elastic