Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/prebuilt_rules/prebuilt_rules_install_update_workflows·cy·ts - Detection rules, Prebuilt Rules Installation and Update workflow Installation of prebuilt rules package via Fleet should install rules from the Fleet package when user clicks on CTA should install rules from the Fleet package when user clicks on CTA #168897

Closed
Tracked by #165359
kibanamachine opened this issue Oct 13, 2023 · 13 comments · Fixed by #169842
Assignees
Labels
8.12 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 13, 2023

A test failed on a tracked branch

AssertionError: Timed out retrying after 150000ms: expected '<button.euiButton.css-vdoabi-euiButtonDisplay-m-defaultMinWidth-isDisabled-fill-disabled>' to be 'enabled'
    at Context.eval (webpack:///./e2e/detection_response/prebuilt_rules/prebuilt_rules_install_update_workflows.cy.ts:112:45)

First failure: CI Build - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 13, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 13, 2023
@kibanamachine kibanamachine added the Team:Detection Rule Management Security Detection Rule Management Team label Oct 13, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 13, 2023
@banderror banderror added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area 8.12 candidate labels Oct 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Oct 24, 2023

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: 3d100ca

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@ashokaditya
Copy link
Member

ashokaditya commented Oct 25, 2023

Thanks for looking into this @jpdjere

The same test is failing also on 8.11 backport PRs

#169314
#169784
#169765

I would suggest this fix PR be backported to 8.11 as well

maximpn pushed a commit that referenced this issue Oct 26, 2023
…tall_update_workflows.cy.ts` Cypress integration test (#169842)

Fixes: #168897

## Summary

Removes flake by waiting for Installation of rules (`/_perform`) to complete before making assertion on the success toaster.

## Flaky test runs

- https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3735 🟢 
- https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3737 [CONTROL - NO CHANGES]
jpdjere added a commit to jpdjere/kibana that referenced this issue Oct 26, 2023
…tall_update_workflows.cy.ts` Cypress integration test (elastic#169842)

Fixes: elastic#168897

## Summary

Removes flake by waiting for Installation of rules (`/_perform`) to complete before making assertion on the success toaster.

## Flaky test runs

- https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3735 🟢
- https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3737 [CONTROL - NO CHANGES]

(cherry picked from commit 79b1a87)

# Conflicts:
#	x-pack/test/security_solution_cypress/package.json
jpdjere referenced this issue Oct 26, 2023
…les_install_update_workflows.cy.ts` Cypress integration test (#169842) (#169934)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution ] Fix flake in
`/prebuilt_rules/prebuilt_rules_install_update_workflows.cy.ts` Cypress
integration test
(#169842)](#169842)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Juan Pablo
Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-26T13:13:22Z","message":"[Security
Solution ] Fix flake in
`/prebuilt_rules/prebuilt_rules_install_update_workflows.cy.ts` Cypress
integration test (#169842)\n\nFixes:
https://github.com/elastic/kibana/issues/168897\r\n\r\n##
Summary\r\n\r\nRemoves flake by waiting for Installation of rules
(`/_perform`) to complete before making assertion on the success
toaster.\r\n\r\n## Flaky test runs\r\n\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3735
🟢 \r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3737
[CONTROL - NO
CHANGES]","sha":"79b1a877b0b0571aaaa21b7a313512bf5d16f70b","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","v8.11.0","v8.12.0"],"number":169842,"url":"https://github.com/elastic/kibana/pull/169842","mergeCommit":{"message":"[Security
Solution ] Fix flake in
`/prebuilt_rules/prebuilt_rules_install_update_workflows.cy.ts` Cypress
integration test (#169842)\n\nFixes:
https://github.com/elastic/kibana/issues/168897\r\n\r\n##
Summary\r\n\r\nRemoves flake by waiting for Installation of rules
(`/_perform`) to complete before making assertion on the success
toaster.\r\n\r\n## Flaky test runs\r\n\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3735
🟢 \r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3737
[CONTROL - NO
CHANGES]","sha":"79b1a877b0b0571aaaa21b7a313512bf5d16f70b"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169842","number":169842,"mergeCommit":{"message":"[Security
Solution ] Fix flake in
`/prebuilt_rules/prebuilt_rules_install_update_workflows.cy.ts` Cypress
integration test (#169842)\n\nFixes:
https://github.com/elastic/kibana/issues/168897\r\n\r\n##
Summary\r\n\r\nRemoves flake by waiting for Installation of rules
(`/_perform`) to complete before making assertion on the success
toaster.\r\n\r\n## Flaky test runs\r\n\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3735
🟢 \r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3737
[CONTROL - NO
CHANGES]","sha":"79b1a877b0b0571aaaa21b7a313512bf5d16f70b"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.12 candidate failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
6 participants