[8.11] [APM] Modify has_any_service telemetry (#166925)
#168895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary fixes elastic/observability-bi#65 ## Context Observability-bi uses the [signal](https://docs.elastic.dev/observability-bi/observability-marker#signals) `has_apm_services` based on the telemetry field `has_any_services` to determine whether a cluster has documents for at least one APM service for the given day. ## Problem Previously we determined if the cluster has any service by checking ONLY the officially supported agents. There might be cases where the cluster has agents that are not on the agent's list. Leading to the wrong result. Modified to check if there is any document with the field `service.name` and added `has_any_services_per_official_agent` to track the official agent's services ### Side effects Modifying `has_any_service` telemetry (most likely) will increase the metrics using this field. --------- Co-authored-by: Achyut Jhunjhunwala <[email protected]> (cherry picked from commit c83f5db)
|
Pinging @elastic/apm-ui (Team:APM) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpatticha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:has_any_servicetelemetry (#166925)Questions ?
Please refer to the Backport tool documentation