Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12] Rename some alert -> rule and action -> connector terminology in the code #168861

Open
mikecote opened this issue Oct 13, 2023 · 1 comment
Open

[8.12] Rename some alert -> rule and action -> connector terminology in the code #168861

mikecote opened this issue Oct 13, 2023 · 1 comment
Labels
response-ops-ec-backlog ResponseOps E&C backlog Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@mikecote
Copy link
Contributor

mikecote commented Oct 13, 2023 •
edited
Loading

We should timebox up to 2 days in 8.12 to continue renaming the terminology in our codebase where it is out of date.

Some examples include:

  • partially_update_alert.ts where it's really partially updating a rule
  • Store confusing names into variables, like const RULE_SO_TYPE = 'alert'; so we only see alert once with a comment on top.. and re-use it when calling different functions like createInternalRepository([RULE_SO_TYPE])
@mikecote mikecote added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote mikecote changed the title Rename some alert -> rule and action -> connector terminology in the code [8.12] Rename some alert -> rule and action -> connector terminology in the code Oct 13, 2023
@mikecote mikecote added the technical debt Improvement of the software architecture and operational architecture label Oct 13, 2023
@mikecote mikecote moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Oct 13, 2023
@ymao1 ymao1 mentioned this issue Dec 7, 2023
Merged
ymao1 added a commit that referenced this issue Dec 18, 2023
@ymao1 @kibanamachine
[Response Ops][Alerting] Refactoring rule SO const and `partiallyUpda…
74b1e12 
…teAlert` -> `partiallyUpdateRule` (#172859)

Towards #168861

## Summary

* Adding `RULE_SAVED_OBJECT_TYPE = 'alert'` and using it everywhere
* Rename `partiallyUpdateAlert` fn to `partiallyUpdateRule`

Using this const in place of `alert` changed so many files that I
limited this PR to just these changes.

---------

Co-authored-by: kibanamachine <[email protected]>
@doakalexi doakalexi self-assigned this Feb 2, 2024
@doakalexi doakalexi moved this from Todo to In Progress in AppEx: ResponseOps - Execution & Connectors Feb 6, 2024
@doakalexi doakalexi moved this from In Progress to Todo in AppEx: ResponseOps - Execution & Connectors Feb 12, 2024
@mikecote mikecote moved this from Todo to In Progress in AppEx: ResponseOps - Execution & Connectors Feb 14, 2024
@doakalexi doakalexi moved this from In Progress to In Review in AppEx: ResponseOps - Execution & Connectors Mar 19, 2024
@doakalexi doakalexi mentioned this issue Mar 19, 2024
Merged
@doakalexi doakalexi removed their assignment Mar 19, 2024
doakalexi added a commit that referenced this issue Mar 20, 2024
@doakalexi
[ResponseOps] Rename some alert -> rule terminology in the code (#178988
38be4d7 
)

Related to #168861

## Summary

This is a tech debt issue that I made a little progress on, I made some
changes to rename alert -> rule. It's an ongoing task, but I made a PR
for my changes so I can release the issue back to the iteration.

Nothing to verify, just make sure that the build passes.
@mikecote mikecote added the response-ops-ec-backlog ResponseOps E&C backlog label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
response-ops-ec-backlog ResponseOps E&C backlog Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikecote @elasticmachine @doakalexi