Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration should not be used as plural when zero/one integration is added to the policy #168584

Open
muskangulati-qasource opened this issue Oct 11, 2023 · 6 comments
Assignees
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@muskangulati-qasource
Copy link

muskangulati-qasource commented Oct 11, 2023

Description:
Integration should not be used as plural when zero/one integration is added to the policy

Build Details:

Version: 8.11.0
Commit: 636a8339cfad92998a5a5adb7be81e3546525ebf
Build: 67841

Browser Details:
All

Steps to Reproduce:

  1. Create a Serverless project from the QA console platform
  2. Login into the same and navigate to the asset tab --> fleet tab
  3. Create a policy with no integration
  4. Click on 'Add agent' for the policy with no integration

Actual Result:
Integration is used as plural when zero/one integration is added to the policy

Expected Result:
Integration should not be used as plural when zero/one integration is added to the policy

Screenshot:
FleetDefaultPolicy

Logs
N/A

@muskangulati-qasource muskangulati-qasource added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@muskangulati-qasource muskangulati-qasource changed the title [Security Solution] [Serverless] Integration should not be used as plural when zero/one integration is added to the policy Oct 11, 2023
@muskangulati-qasource muskangulati-qasource added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution and removed triage_needed labels Oct 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@muskangulati-qasource muskangulati-qasource added Project:Serverless Work as part of the Serverless project for its initial release v8.11.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 11, 2023
@muskangulati-qasource
Copy link
Author

@manishgupta-qasource please review!

@manishgupta-qasource
Copy link

Reviewed & assigned to @kevinlog

@ashokaditya
Copy link
Member

@muskangulati-qasource Thanks for pointing this out. Although I feel the description of the action is generic and is okay to have plural hosts or agents in the info.

I do notice that the Enroll in Fleet radio descriptions are using singular nouns and that maybe updated to use plural as well to make everything consistent. I also notice that there's a typo error in Enroll in Fleet radio and it should say Enroll an Elastic Agent... instead of Enroll in Elastic Agent.... That could also be updated as part of the text update.

cc @kevinlog

@kevinlog kevinlog removed the Project:Serverless Work as part of the Serverless project for its initial release label Nov 1, 2023
@kevinlog
Copy link
Contributor

kevinlog commented Nov 1, 2023

removing from serverless project since it's not serverless specific

@kevinlog kevinlog changed the title [Serverless] Integration should not be used as plural when zero/one integration is added to the policy Integration should not be used as plural when zero/one integration is added to the policy Nov 1, 2023
@MindyRS MindyRS removed bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0 labels Dec 12, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 12, 2023
@wayneseymour wayneseymour added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Dec 12, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

7 participants