Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] User is not able to create/edit an exception after an error has been displayed #168217

Closed
MadameSheema opened this issue Oct 6, 2023 · 3 comments
Closed

[Security Solution] User is not able to create/edit an exception after an error has been displayed #168217

MadameSheema opened this issue Oct 6, 2023 · 3 comments
Assignees
@e40pud
Labels
bug Fixes for quality problems that affect the customer experience consider-next fixed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Serverless Work as part of the Serverless project for its initial release Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0

Comments

@MadameSheema
Copy link
Member

MadameSheema commented Oct 6, 2023 •
edited
Loading

Describe the bug:

  • User is not able to create/edit an exception after an error has been displayed

Kibana/Elasticsearch Stack version:

  • Serverless production

Initial setup:

  • To have an errored exception flyout
  • You can do it by following the steps mentioned here

Steps to reproduce:

  1. Click the Dismiss button on the top of the exceptions flyout
  2. Delete the long comment
  3. Add a regular comment

Current behavior:

  • The Add rule exception button is disabled
Screenshot 2023-10-06 at 15 02 21

Expected behavior:

  • After correcting all the errors, the Add rule exception button should be enabled.
  • The user should be able to create a rule exception when all the entered fields are valid.

Additional information:

  • The same behaviour happens when instead of a creation an edition is performed.
  • This issue was found during the testing spike, the same behavior it might happen on ESS.
@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Project:Serverless Work as part of the Serverless project for its initial release labels Oct 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MikePaquette MikePaquette added the impact:critical This issue should be addressed immediately due to a critical level of impact on the product. label Oct 12, 2023
@yctercero yctercero removed their assignment Oct 13, 2023
e40pud added a commit to e40pud/kibana that referenced this issue Oct 25, 2023
@e40pud
[Security Solution] User is not able to create/edit an exception afte…
435fc9b 
…r an error has been displayed elastic#168217
@e40pud e40pud mentioned this issue Oct 25, 2023
Merged
e40pud added a commit that referenced this issue Oct 27, 2023
@e40pud
[Security Solution] User is not able to create/edit an exception afte…
537af2f 
…r an error has been displayed (#168217) (#169801)

## Summary

These changes fixes the issue where user is not able to create/edit an
exception after an error has been displayed. That happens due to not
re-setting loading state to `false` on exception being thrown.

Addressing #168217
@e40pud e40pud added the fixed label Oct 27, 2023
@e40pud
Copy link
Contributor

e40pud commented Oct 27, 2023

@MadameSheema this bug was fixed and merged into main branch

@michaelolo24 michaelolo24 removed the Team:Threat Hunting:Investigations Security Solution Investigations Team label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e40pud e40pud

Labels
bug Fixes for quality problems that affect the customer experience consider-next fixed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Serverless Work as part of the Serverless project for its initial release Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0
Projects
Security Bug Audit
Status: To do
Milestone
No milestone
Development

No branches or pull requests
6 participants
@e40pud @yctercero @elasticmachine @michaelolo24 @MadameSheema @MikePaquette