Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Filter in and out not working in show top modal inside timeline #168199

Closed
ghost opened this issue Oct 6, 2023 · 5 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0

Comments

@ghost
Copy link

ghost commented Oct 6, 2023

Describe the bug:
Filter in and out not working in show top modal inside timeline

Kibana/Elasticsearch Stack version
Version:8.10.3
commit:5aee3c4fba328838fcf0be6a3ff2248a4c0120dd
build:66480

Version:8.10.0 Release

Browser and Browser OS Version:
Firefox for windows OS
Version: 118.0.1

Elastic Endpoint Version:
8.10.2

Original install method:
None

Functional Area:
Show Top filter Actions

Initial Setup:

  • None

Steps to reproduce

  • Create timeline with any query
  • open show top modal and perform filter in and filter out on the data present inside it
  • validate filter in and out not working

Additional Observation

  • Issue is also occuring on 8.10.0
  • Add to Timeline and copy to clipboard actions are working correctly inside show top modal

Current behavior

  • Filter in and out not working in show top modal inside timeline

Expected behavior:

  • Filter in and out should work in show top modal inside timeline

Screen-Shot:

Timelines.-.Kibana.Mozilla.Firefox.2023-10-06.16-06-52.mp4

Errors in browser console:

None

Any additional context (logs, chat logs, magical formulas, etc.):

None

@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Oct 6, 2023
@ghost ghost assigned MadameSheema Oct 6, 2023
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Oct 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@machadoum
Copy link
Member

This bug was also reported here: https://github.com/elastic/security-team/issues/7748

angorayc added a commit that referenced this issue Oct 31, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ine (#170127)

## Summary

#168199
#169656


https://github.com/elastic/kibana/assets/6295984/ff5cee55-6da5-4636-85f5-a697a302f8b5

---------

Co-authored-by: Michael Olorunnisola <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 31, 2023
kibanamachine added a commit that referenced this issue Nov 1, 2023
…n timeline (#170127) (#170269)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[SecuritySolution] Fix topN legend actions - filter in / out in
timeline (#170127)](#170127)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-31T17:30:08Z","message":"[SecuritySolution]
Fix topN legend actions - filter in / out in timeline (#170127)\n\n##
Summary\r\n\r\nhttps://github.com//issues/168199\r\nhttps://github.com//issues/169656\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/ff5cee55-6da5-4636-85f5-a697a302f8b5\r\n\r\n---------\r\n\r\nCo-authored-by:
Michael Olorunnisola
<[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"8103a445855f72dd1755a4fd4364e4573ec6a194","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ExpressionLanguage","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","Feature:Lens
Charts","v8.11.0","v8.12.0","v8.11.1"],"number":170127,"url":"https://github.com/elastic/kibana/pull/170127","mergeCommit":{"message":"[SecuritySolution]
Fix topN legend actions - filter in / out in timeline (#170127)\n\n##
Summary\r\n\r\nhttps://github.com//issues/168199\r\nhttps://github.com//issues/169656\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/ff5cee55-6da5-4636-85f5-a697a302f8b5\r\n\r\n---------\r\n\r\nCo-authored-by:
Michael Olorunnisola
<[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"8103a445855f72dd1755a4fd4364e4573ec6a194"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170127","number":170127,"mergeCommit":{"message":"[SecuritySolution]
Fix topN legend actions - filter in / out in timeline (#170127)\n\n##
Summary\r\n\r\nhttps://github.com//issues/168199\r\nhttps://github.com//issues/169656\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/ff5cee55-6da5-4636-85f5-a697a302f8b5\r\n\r\n---------\r\n\r\nCo-authored-by:
Michael Olorunnisola
<[email protected]>\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"8103a445855f72dd1755a4fd4364e4573ec6a194"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
Co-authored-by: Michael Olorunnisola <[email protected]>
@michaelolo24
Copy link
Contributor

@karanbirsingh-qasource - can you please verify this fix? It made it into 8.11.0. Thank you!

@ghost
Copy link
Author

ghost commented Nov 15, 2023

Hi @michaelolo24

we have validated this issue on 8.11 Release and found the issue to be fixed ✔️ . Additional Filter is working correctly.

Build Details:

Version: 8.11.0
Commit: f2ea0c43ec0d854259d63d926b97e5c556b5f6b2
Build: 68160

Screen-Cast:

Alerts.-.Kibana.Mozilla.Firefox.2023-11-15.11-36-40.mp4

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks!!

@ghost ghost closed this as completed Nov 15, 2023
@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 15, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0
Projects
None yet
Development

No branches or pull requests

6 participants