Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Share dashboards] All related objects will be automatically shared and show detailed results #167956

Closed
Tracked by #167901 ...
teresaalvarezsoler opened this issue Oct 4, 2023 · 15 comments · May be fixed by #170375
Closed
Tracked by #167901 ...
Assignees
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:ShareToSpace Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@teresaalvarezsoler
Copy link

teresaalvarezsoler commented Oct 4, 2023

Describe the feature:
Dataviews, panels and related dashboards (linked via drilldowns or the links panel) will automatically be shared in the destination space/s. Also all the objects from related dashboards (dataviews, panels and related dashboards).

Related objects can have 2 different status:

  • Shared: it is shared at the same time than the dashboard or it was already shared in the destination space
  • Error: it throws an error because of any reason

We should differentiate sharing from unsharing like in the image below:

image
@teresaalvarezsoler teresaalvarezsoler added the Feature:Dashboard Dashboard related features label Oct 4, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 4, 2023
@teresaalvarezsoler teresaalvarezsoler added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels Oct 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 4, 2023
@cqliu1
Copy link
Contributor

cqliu1 commented Oct 23, 2023

@teresaalvarezsoler Just to clarify on the unshare use cases listed above:

  1. Users unshare a dashboard from a space

This is referring to unsharing a dashboard(s) from the dashboard listing page within the Dashboard app when you're trying to remove a shared dashboard(s) from a single space, correct? I.e. this issue: #167959

  1. Users unshare a dashboard from a space and share it in another at the same time

This is referring to sharing/unsharing to a space(s) a single dashboard saved object from the saved object management page, right? I.e. this issue: #167953

@teresaalvarezsoler
Copy link
Author

@cqliu1 sorry for the confusion, it was not very clear. Both cases are referring to #167953. But you are right they seem redundant, I will just remove them from this issue.

@andreadelrio
Copy link
Contributor

Describe the feature: Dataviews, panels and related dashboards (linked via drilldowns or the links panel) will automatically be shared in the destination space/s. Also all the objects from related dashboards (dataviews, panels and related dashboards).

Related objects can have 3 different status:

  • Shared: it is shared at the same time than the dashboard
  • Already shared: it was already shared in the space before the dashboard
  • Error: it throws an error because of any reason

@teresaalvarezsoler for the UI, could we refer to "already shared" as "skipped"?

@teresaalvarezsoler
Copy link
Author

hey @andreadelrio if we say "skipped" the user may think the object hasn't been shared to the space. I preferred "already shared" to be similar to the "already copied" when copying dashboards. We show a simple check mark without the green circle and a tooltip when user hovers like this:
image

@teresaalvarezsoler
Copy link
Author

Not sure how the "skipped" status can be applied to sharing objects. Under which circumstances is an object skipped?

@andreadelrio
Copy link
Contributor

Not sure how the "skipped" status can be applied to sharing objects. Under which circumstances is an object skipped?

@cqliu1 @nickpeihl can you confirm whether skipped is a plausible status for the related objects when a dashboard is shared?

@nickpeihl
Copy link
Member

Not sure how the "skipped" status can be applied to sharing objects. Under which circumstances is an object skipped?

@cqliu1 @nickpeihl can you confirm whether skipped is a plausible status for the related objects when a dashboard is shared?

Good question. The _update_objects_spaces API does not actually tell us if the related objects already exist in the space (i.e. sharing was "skipped"). The API only tells us if there was a problem sharing an object. Would it be ok to show one of two icons, checkMark or error?

@andreadelrio
Copy link
Contributor

Not sure how the "skipped" status can be applied to sharing objects. Under which circumstances is an object skipped?

@cqliu1 @nickpeihl can you confirm whether skipped is a plausible status for the related objects when a dashboard is shared?

Good question. The _update_objects_spaces API does not actually tell us if the related objects already exist in the space (i.e. sharing was "skipped"). The API only tells us if there was a problem sharing an object. Would it be ok to show one of two icons, checkMark or error?

From my perspective, this is good enough.

@teresaalvarezsoler
Copy link
Author

From my perspective two status is fine too, thanks @nickpeihl

@cqliu1
Copy link
Contributor

cqliu1 commented Oct 30, 2023

@andreadelrio What should it look like when I simultaneously share a dashboard to a space(s) but also unshare from an space(s), or when I only unshare from a space(s)?

I imagine we would just have a different icon when an object is unshared? Or do we also want to use the success checkmark to show the unsharing was successful but have a separate subsection showing all the removed/unshared objects?

@andreadelrio
Copy link
Contributor

andreadelrio commented Oct 31, 2023

@andreadelrio What should it look like when I simultaneously share a dashboard to a space(s) but also unshare from an space(s), or when I only unshare from a space(s)?

I imagine we would just have a different icon when an object is unshared? Or do we also want to use the success checkmark to show the unsharing was successful but have a separate subsection showing all the removed/unshared objects?

Sending a few options after discussing over Zoom with @cqliu1. For the following screens assume that the dashboard is shared to John's Space and unshared from Target Space in the same action.

1. Showing a green check for successfully shared and blue check for successfully unshared. A tooltip appears on hover.

image

2. Doing (1) but using different icons

image

3. Having two different sections: one for displaying results of share actions and another for the results of unshare actions. Each section has a heading and a list of accordions.

image

Let me know what you think @teresaalvarezsoler @nickpeihl @cqliu1

@teresaalvarezsoler
Copy link
Author

I like making the two sections clear (share vs unshare), regarding the icons, either number 1 or number 2 work fine, no strong preferences from my side, but the tooltip is necessary. One question, if this lists gets very long, I guess users will be able to scroll @andreadelrio?
image

@nickpeihl
Copy link
Member

One question, if this lists gets very long, I guess users will be able to scroll @andreadelrio?

It looks like the Spaces are collapsible. We might even consider collapsing the Space list by default. The user would be able to expand the list and scrolling should still work.

@cqliu1 cqliu1 changed the title [Share dashboards] All related objects will be automatically shared along with dashboards [Share dashboards] All related objects will be automatically shared along with dashboards and show detailed results Nov 22, 2023
@cqliu1 cqliu1 changed the title [Share dashboards] All related objects will be automatically shared along with dashboards and show detailed results [Share dashboards] All related objects will be automatically shared and show detailed results Nov 22, 2023
@nreese
Copy link
Contributor

nreese commented Jul 17, 2024

Closing, issue iceboxed in #188573

@nreese nreese closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:ShareToSpace Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants