-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Share dashboards] All related objects will be automatically shared and show detailed results #167956
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
@teresaalvarezsoler Just to clarify on the unshare use cases listed above:
This is referring to unsharing a dashboard(s) from the dashboard listing page within the Dashboard app when you're trying to remove a shared dashboard(s) from a single space, correct? I.e. this issue: #167959
This is referring to sharing/unsharing to a space(s) a single dashboard saved object from the saved object management page, right? I.e. this issue: #167953 |
@teresaalvarezsoler for the UI, could we refer to "already shared" as "skipped"? |
hey @andreadelrio if we say "skipped" the user may think the object hasn't been shared to the space. I preferred "already shared" to be similar to the "already copied" when copying dashboards. We show a simple check mark without the green circle and a tooltip when user hovers like this: |
Not sure how the "skipped" status can be applied to sharing objects. Under which circumstances is an object skipped? |
@cqliu1 @nickpeihl can you confirm whether |
Good question. The _update_objects_spaces API does not actually tell us if the related objects already exist in the space (i.e. sharing was "skipped"). The API only tells us if there was a problem sharing an object. Would it be ok to show one of two icons, |
From my perspective, this is good enough. |
From my perspective two status is fine too, thanks @nickpeihl |
@andreadelrio What should it look like when I simultaneously share a dashboard to a space(s) but also unshare from an space(s), or when I only unshare from a space(s)? I imagine we would just have a different icon when an object is unshared? Or do we also want to use the success checkmark to show the unsharing was successful but have a separate subsection showing all the removed/unshared objects? |
Sending a few options after discussing over Zoom with @cqliu1. For the following screens assume that the dashboard is shared to John's Space and unshared from Target Space in the same action. 1. Showing a green check for
|
I like making the two sections clear (share vs unshare), regarding the icons, either number 1 or number 2 work fine, no strong preferences from my side, but the tooltip is necessary. One question, if this lists gets very long, I guess users will be able to scroll @andreadelrio? |
It looks like the Spaces are collapsible. We might even consider collapsing the Space list by default. The user would be able to expand the list and scrolling should still work. |
Closing, issue iceboxed in #188573 |
Describe the feature:
Dataviews, panels and related dashboards (linked via drilldowns or the links panel) will automatically be shared in the destination space/s. Also all the objects from related dashboards (dataviews, panels and related dashboards).
Related objects can have 2 different status:
We should differentiate sharing from unsharing like in the image below:
The text was updated successfully, but these errors were encountered: