Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Incorrect rule count on MITRE coverage tactic cell #167930

Closed
approksiu opened this issue Oct 3, 2023 · 11 comments
Closed

[Security Solution] Incorrect rule count on MITRE coverage tactic cell #167930

approksiu opened this issue Oct 3, 2023 · 11 comments
Assignees
Labels
8.12 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.1 v8.12.0

Comments

@approksiu
Copy link

Describe the bug:
Rule is duplicated in the mitre att&ck page cell

Kibana/Elasticsearch Stack version:
8.10.2, 8.10.3

Server OS version:

Browser and Browser OS versions:

Elastic Endpoint version:

Original install method (e.g. download page, yum, from source, etc.):

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):

Steps to reproduce:

  1. Install all rules, enable them
  2. Go to MITRE ATT&CK page
  3. Search for T1546.015 (as an example)
  4. Check rule counts on the tactic tile for "Persistance" and "Privilege Escalation"

Current behavior:
The rule count is 1 on Persistance, and 0 on Privilege Escalation.

Expected behavior:
The rule count is 1 on Persistance, and 1 on Privilege Escalation.

Screenshots (if relevant):
image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):

@approksiu approksiu added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@approksiu approksiu changed the title [Security Solution] [Security Solution] Incorrect rule count on MITRE coverage tactic cell Oct 3, 2023
@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team labels Oct 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Rule Management Security Solution Detection Rule Management area 8.11 candidate v8.11.0 and removed triage_needed labels Oct 4, 2023
@banderror banderror assigned dplumlee and unassigned banderror Oct 4, 2023
@banderror
Copy link
Contributor

banderror commented Oct 4, 2023

@dplumlee Let's sync and see if we could quickly fix this in 8.11

@maximpn
Copy link
Contributor

maximpn commented Oct 6, 2023

@dplumlee @banderror I checked this behavior locally. It's Component Object Model Hijacking prebuilt rule. According to the docs it has the following categories

Tactic:

Name: Persistence
ID: TA0003
Reference URL: https://attack.mitre.org/tactics/TA0003/
Technique:

Name: Event Triggered Execution
ID: T1546
Reference URL: https://attack.mitre.org/techniques/T1546/
Sub-technique:

Name: Component Object Model Hijacking
ID: T1546.015
Reference URL: https://attack.mitre.org/techniques/T1546/015/

so we should expect it in Persistence, Event Triggered Execution and Component Object Model Hijacking cards. But for some reason it's in Persistence, listed twice in Event Triggered Execution

image

and not listed at al in Component Object Model Hijacking.

The API endpoint returns the correct result

{
    "coverage": {
        "TA0003": [
            "3e8736a0-4718-11ee-a876-8955b5f07a55"
        ],
        "T1546": [
            "3e8736a0-4718-11ee-a876-8955b5f07a55"
        ],
        "T1546.015": [
            "3e8736a0-4718-11ee-a876-8955b5f07a55"
        ]
    },
    "unmapped_rule_ids": [],
    "rules_data": {
        "3e8736a0-4718-11ee-a876-8955b5f07a55": {
            "name": "Component Object Model Hijacking",
            "activity": "disabled"
        }
    }
}

so I'd say it's a purely UI bug.

@approksiu I'm curious from where did Privilege Escalation come from?

@approksiu
Copy link
Author

@maximpn

and not listed at al in Component Object Model Hijacking.

The Component Object Model Hijacking technique has moved as subtechnique under Event triggered Execution (T1546) technique, so that rule should not show up there. The old techniques showing up on the page issue has been fixed.

I'm curious from where did Privilege Escalation come from?

While the rule is not explicitly mapped to Privilege Escalation tactic, it does show up on the Event triggered Execution tile under Privilege Escalation tactic.
image

@maximpn
Copy link
Contributor

maximpn commented Oct 6, 2023

@approksiu

The Component Object Model Hijacking technique has moved as subtechnique under Event triggered Execution (T1546) technique, so that rule should not show up there. The old techniques showing up on the page issue has been fixed.

Interesting, there are two cards Component Object Model Hijacking with id T1546.015

image

the rule has a sub-technique assigned

image

so I'd expect the rule to appear in these cards.

My point is that UI doesn't correspond to API response and the rule is listed twice in one card. It's definitely a bug.

While the rule is not explicitly mapped to Privilege Escalation tactic, it does show up on the Event triggered Execution tile under Privilege Escalation tactic.

This is how the algorithm works right now. It just maps existing tactics/techniques/sub-techniques to rules based on the coverage params. If something isn't specified it just gets skipped. It can be fixed by enriching the parent category when building the rules coverage mapping.

@banderror
Copy link
Contributor

My point is that UI doesn't correspond to API response and the rule is listed twice in one card. It's definitely a bug.

++ Most definitely, there's a bug in the code that processes the API response on the FE side before showing the grid. The #167917 PR doesn't fix this. TY @maximpn for the investigation!

@maximpn
Copy link
Contributor

maximpn commented Oct 7, 2023

@dplumlee we should have scenarios in the test plan covering behavior described in this ticket. In particular UI/backend properly handles properly techniques/sub-techniques encountered in different tactics. As far as I remember we don't have such scenarios described right now.

@banderror
Copy link
Contributor

banderror commented Nov 7, 2023

@vgomez-el Fixed by #169708 and should be available in the last 8.11.0 BC 8.11.1 and the first BC for this patch release. Context: #169708 (comment)

@banderror banderror added v8.11.1 and removed v8.11.0 labels Nov 7, 2023
@banderror
Copy link
Contributor

Closing for the same reason as #167929 (comment)

@ghost
Copy link

ghost commented Dec 7, 2023

hi @approksiu

we have validated this issue on 8.11.2 and on filtering data using "T1546.015" on mittre dashboard with all rules enabled we are getting correct rule counts on the tactic tile for "Persistance" and "Privilege Escalation" ✔️

Build details:

Version: 8.11.2
Commit: 92746356b61c3e3ac62b6d7045727f8d737fa4b5
Build:68299

Screen-Shot

image

image

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost added the QA:Validated Issue has been validated by QA label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.12 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management area fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.1 v8.12.0
Projects
None yet
Development

No branches or pull requests

6 participants