Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZDT update limitation to only bulkUpdate #167200

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Sep 25, 2023

Summary

We've fixed the update limitation (#152807), so now it only applies to bulkUpdates #165434

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes labels Sep 25, 2023
@rudolf rudolf self-assigned this Sep 25, 2023
@rudolf rudolf requested a review from a team as a code owner September 25, 2023 21:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf rudolf merged commit 12f04e7 into elastic:main Sep 26, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 26, 2023
@rudolf rudolf deleted the update-zdt-docs branch September 26, 2023 12:29
@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Nov 26, 2023

BWC bulkUpdate PR is in review and we'll need to update the doc. cc @rudolf FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants