Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Log Explorer] Show data views in a selector tab #166848

Closed
weltenwort opened this issue Sep 20, 2023 · 1 comment · Fixed by #166938
Closed

[Log Explorer] Show data views in a selector tab #166848

weltenwort opened this issue Sep 20, 2023 · 1 comment · Fixed by #166938
Assignees
@tonyghiani
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Sep 20, 2023 •
edited by tonyghiani
Loading

📓 Summary

In order to keep as many users in the Log Explorer app as possible, we want to include some legacy index selection concepts in the dataset selector. As a start we want to list the Kibana data views and offer a convenient way to open them in Discover. This is just an intermediate step.

✔️ Acceptance criteria

  • There is a "Data views" tab in the dataset selector's pop-over.
  • That tab lists the data views as received by the data_views service.
  • The list of data views can be filtered and sorted like in the other tabs.
  • Clicking on an entry navigates the user to Discover with the data view selected.
  • The data views list title will have a badge to communicate to users they are navigating to Discover
  • It is possible to detect that navigation in FullStory so we can learn about its usage.

🎨 Mock-ups

⚠ Some aspects described in the acceptance criteria might not be reflected in the mock-up.

Screenshot 2023-09-21 at 11 05 03

💡 Implementation considerations

  • Since the data view find API doesn't support pagination, the initial fetch will receive all of them. And since the dataset selector has them all in memory anyway, it can just filter and sort in-memory without an additional round-trip.
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@tonyghiani tonyghiani self-assigned this Sep 20, 2023
@tonyghiani tonyghiani mentioned this issue Sep 21, 2023
Merged
tonyghiani added a commit that referenced this issue Sep 28, 2023
@tonyghiani @kibanamachine
[Log Explorer] Implement Data Views tab into selector (#166938)
3be21c9 
## 📓 Summary

Closes #166848 

This work adds a new tab to navigate Data View from the Log Explorer
selector.
In this first iteration, when the user selects a data view, we move into
discovering preselecting and loading the data view of choice.

**N.B.**: this recording is made on a setup where I have no installed
integrations, so having the no integrations panel is the expected
behaviour.


https://github.com/elastic/kibana/assets/34506779/e8d1f622-86fb-4841-b4cc-4a913067d2cc

## Updated selector state machine

<img width="1492" alt="Screenshot 2023-09-22 at 12 15 44"
src="https://github.com/elastic/kibana/assets/34506779/c563b765-6c6c-41e8-b8cd-769c518932c3">

## New DataViews state machine

<img width="995" alt="Screenshot 2023-09-22 at 12 39 09"
src="https://github.com/elastic/kibana/assets/34506779/e4e43343-c915-42d8-8660-a2ee89f8d595">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs Explorer] Implement Data Views tab into selector tonyghiani/kibana
4 participants
@weltenwort @gbamparop @elasticmachine @tonyghiani